[LTB-52] Remove tag in HasLens typeclass
#45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During our work in Disciplina project we haven't enconutered a case when tag was useful. When one wants to distiguish between two entities of the same type, adding a phantom type parameter to types of that entities is usually a better way.
Martoon-00
force-pushed
the
martoon/ltb52-simplier-has-len
branch
from
8b35882 to
9ddc9a4
Compare
|
We have decided not to perform any changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During our work in Disciplina project, we haven't encountered a case when the tag parameter was useful.
When one wants to distinguish between two entities of the same type, adding a phantom
type parameter to types of that entities is usually a better way.
This PR is part #28 with the only changes which we need in Disciplina.