Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

feat(lambda-at-edge): copy additional JS files to handlers #1970

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Oct 27, 2021

  • Needed in Next.js 12
  • There are still some fixes needed to renderReqToHtml function which is currently breaking ISR etc.

@slsnextbot
Copy link
Collaborator

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit 6e27aa9)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1495,
            "Minified": 658
        },
        "Image Lambda": {
            "Standard": 1461,
            "Minified": 792
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1506,
            "Minified": 664
        },
        "Default Lambda V2": {
            "Standard": 1498,
            "Minified": 660
        },
        "API Lambda": {
            "Standard": 632,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1470,
            "Minified": 797
        },
        "Regeneration Lambda": {
            "Standard": 1163,
            "Minified": 537
        },
        "Regeneration Lambda V2": {
            "Standard": 1228,
            "Minified": 564
        }
    }
}

New Handler Sizes (kB) (commit eee88ce)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1495,
            "Minified": 658
        },
        "Image Lambda": {
            "Standard": 1461,
            "Minified": 792
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1506,
            "Minified": 664
        },
        "Default Lambda V2": {
            "Standard": 1498,
            "Minified": 660
        },
        "API Lambda": {
            "Standard": 632,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1470,
            "Minified": 797
        },
        "Regeneration Lambda": {
            "Standard": 1163,
            "Minified": 537
        },
        "Regeneration Lambda V2": {
            "Standard": 1228,
            "Minified": 564
        }
    }
}

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1970 (eee88ce) into master (6e27aa9) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1970      +/-   ##
==========================================
+ Coverage   83.75%   83.79%   +0.03%     
==========================================
  Files         100      100              
  Lines        3601     3609       +8     
  Branches     1134     1140       +6     
==========================================
+ Hits         3016     3024       +8     
  Misses        525      525              
  Partials       60       60              
Impacted Files Coverage Δ
packages/libs/lambda-at-edge/src/build.ts 96.06% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e27aa9...eee88ce. Read the comment docs.

@dphang dphang merged commit e7c81ef into master Oct 27, 2021
@dphang dphang deleted the dphang/copy-js-files branch October 27, 2021 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants