Use basepath in s3 assets

[TowardsDeath]

I ran into the problem described in #1620: when using a basePath in the Next.js application, the S3 asset bucket remains empty. There was a fix mentioned in the issue, but no PR yet, so I've taken the liberty to make that change and open this PR. I tried the change locally and it worked.

@dphang or any other maintainer: I'm of course willing to add tests, but I couldn't figure out how to integrate such a basePath test with the existing CDK tests.

[slsnextbot]

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit aab033f)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1525,
            "Minified": 668
        },
        "Image Lambda": {
            "Standard": 1489,
            "Minified": 802
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1534,
            "Minified": 674
        },
        "Default Lambda V2": {
            "Standard": 1527,
            "Minified": 670
        },
        "API Lambda": {
            "Standard": 634,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1497,
            "Minified": 807
        },
        "Regeneration Lambda": {
            "Standard": 1184,
            "Minified": 545
        },
        "Regeneration Lambda V2": {
            "Standard": 1254,
            "Minified": 573
        }
    }
}

New Handler Sizes (kB) (commit b36be83)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1525,
            "Minified": 668
        },
        "Image Lambda": {
            "Standard": 1489,
            "Minified": 802
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1534,
            "Minified": 674
        },
        "Default Lambda V2": {
            "Standard": 1527,
            "Minified": 670
        },
        "API Lambda": {
            "Standard": 634,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1497,
            "Minified": 807
        },
        "Regeneration Lambda": {
            "Standard": 1184,
            "Minified": 545
        },
        "Regeneration Lambda V2": {
            "Standard": 1254,
            "Minified": 573
        }
    }
}

[codecov]

Codecov Report

Merging #2265 (b36be83) into master (aab033f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2265      +/-   ##
==========================================
+ Coverage   83.51%   83.54%   +0.03%     
==========================================
  Files         102      102              
  Lines        3669     3671       +2     
  Branches     1167     1169       +2     
==========================================
+ Hits         3064     3067       +3     
+ Misses        593      592       -1     
  Partials       12       12              

Impacted Files	Coverage Δ
...rless-components/nextjs-cdk-construct/src/index.ts	93.39% <100.00%> (+0.12%)	⬆️
packages/libs/core/src/images/imageOptimizer.ts	80.17% <0.00%> (+0.44%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aab033f...b36be83. Read the comment docs.

[dphang]

I think this is fine as it's a small enough change. Thx!

[moshfrid]

i dont know why, but using this new alpha version seems to break isr.

[dphang]

Hm I think from the stacktrace it looks like the error is coming from the Next.js chunks? can you actually find the code where it's failing and see if it's coming from the library? maybe at /var/task/chunks/595.js:417276:13? I didn't change anything in the ISR code but seems like might be some Next.js version issue..maybe there's some compatibility issue with the latest version?

…

On Sat, Jan 22, 2022 at 8:31 AM moshfrid ***@***.***> wrote: i dont know why, but using this new alpha version seems to break isr. [image: image] <https://user-images.githubusercontent.com/20837433/150647163-1a4434f8-8e91-41c9-9256-91855f26c21c.png> — Reply to this email directly, view it on GitHub <#2265 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYSQFFVWAC3WFEXEERSXS3UXLLUVANCNFSM5ME6IOTA> . You are receiving this because you modified the open/close state.Message ID: ***@***.*** com>

[moshfrid]

To be honest Im very confused, here's the function that's failing

[TowardsDeath]

I've had this error as well with Next, even before this change, so my guess is that it's not serverless-nextjs' fault. I haven't yet investigated what could be the cause.

[moshfrid]

@DoNormal I'm not having any issues using the alpha.4 tho