fix: Not crash when runtime is not python (#773)

Co-authored-by: Marco Kleinlein <[email protected]>

Author: jameskbride

.gitignore

@@ -76,3 +76,6 @@ unzip_requirements.py
 # Project ignores
 puck/
 serverless.yml.bak
+
+# Generated packaging
+*.tgz

.python-version

@@ -0,0 +1 @@
+3.7

CONTRIBUTING.md

@@ -12,9 +12,17 @@ Welcome, and thanks in advance for your help!
 
 ## Setup
 
-It is recommended to use Node v14 or v16 for development.
-
-Then, to begin development fork repository and run `npm install` in its root folder.
+Pre-Reqs:
+* Python 3.7
+* [poetry](https://python-poetry.org/docs/) (if you use multiple versions of Python be sure to install it with python 3.7)
+* Perl (used in the tests)
+* Node v14 or v16
+
+Then, to begin development:
+1. fork the repository
+2. `npm install -g serverless@<VERSION>` (check the peer dependencies in the root `package.json` file for the version)
+3. run `npm install` in its root folder
+4. run the tests via `npm run test`
 
 ## Getting started
 

index.js

@@ -66,6 +66,13 @@ class ServerlessPythonRequirements {
         this.serverless.service.custom.pythonRequirements) ||
         {}
     );
+    if (
+      options.pythonBin === this.serverless.service.provider.runtime &&
+      !options.pythonBin.startsWith('python')
+    ) {
+      options.pythonBin = 'python';
+    }
+
     if (options.dockerizePip === 'non-linux') {
       options.dockerizePip = process.platform !== 'linux';
     }

test.js

@@ -1655,6 +1655,18 @@ test('poetry py3.7 fails packaging if poetry.lock is missing and flag requirePoe
   t.end();
 });
 
+test('works with provider.runtime not being python', async (t) => {
+  process.chdir('tests/base');
+  const path = npm(['pack', '../..']);
+  npm(['i', path]);
+  sls(['package'], { env: { runtime: 'nodejs12.x' } });
+  t.true(
+    pathExistsSync('.serverless/sls-py-req-test.zip'),
+    'sls-py-req-test is packaged'
+  );
+  t.end();
+});
+
 test('poetry py3.7 packages additional optional packages', async (t) => {
   process.chdir('tests/poetry_packages');
   const path = npm(['pack', '../..']);