Skip to content

Migrate to encoding_rs crate? #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
talklittle opened this issue Apr 4, 2018 · 4 comments
Closed

Migrate to encoding_rs crate? #444

talklittle opened this issue Apr 4, 2018 · 4 comments

Comments

@talklittle
Copy link

Servo has migrated from rust-encoding to encoding_rs.

Is the plan to do the same migration for rust-url, when using the query_encoding feature?

@SimonSapin
Copy link
Member

The query encoding feature was designed for Servo, but Servo hasn’t been using it so far. And yes, I’d prefer not to bring rust-encoding back into Servo’s dependency graph, so that functionality becomes needed we’ll consider adding a separate Cargo flag.

@talklittle
Copy link
Author

Thanks for the answer. I am interested in this feature for servo/servo#13238

@hsivonen
Copy link
Collaborator

hsivonen commented Apr 5, 2018

Link to old PR on the same topic (of interest particularly for efficient Cow usage).

@nox
Copy link
Contributor

nox commented Jul 18, 2019

There is no encoding crate at all used in this crate anymore.

@nox nox closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants