Skip to content

Separate form_urlencoded into its own crate #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jplatte opened this issue Jun 16, 2020 · 2 comments · Fixed by #607
Closed

Separate form_urlencoded into its own crate #605

jplatte opened this issue Jun 16, 2020 · 2 comments · Fixed by #607

Comments

@jplatte
Copy link
Contributor

jplatte commented Jun 16, 2020

Hi! I'm trying to trim Ruma's dependencies, and noticed that the url crate, of which we only use the form_urlencoded module (which AFAICT doesn't require any external dependencies) is the only reason for the inclusion of idna, unicode-bidi, unicode-normalization and smallvec in our dep graph. Would a PR separating it out into its own crate like percent-encoding be considered?

@valenting
Copy link
Collaborator

Splitting it out would probably be OK, and I think we can do it without breaking the API.

@jplatte
Copy link
Contributor Author

jplatte commented Jun 16, 2020

Awesome! Will work on a PR as soon as I find the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants