Skip to content

Upgrade to 2.5.1 breaks compilation on Windows #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zanieb opened this issue Jun 17, 2024 · 3 comments
Closed

Upgrade to 2.5.1 breaks compilation on Windows #944

zanieb opened this issue Jun 17, 2024 · 3 comments

Comments

@zanieb
Copy link

zanieb commented Jun 17, 2024

In our test workflow for Windows, compilation fails during linking with the latest update. See logs.

= note: LINK : fatal error LNK1318: Unexpected PDB error; LIMIT (12)

Building with 1.78-x86_64-pc-windows-msvc.

Happy to provide more information if I can. I retried the test and it still failed. Per #936 I'll try dropping our crate cache.
@zanieb zanieb mentioned this issue Jun 17, 2024
Merged
1 task
@zanieb
Copy link
Author

zanieb commented Jun 17, 2024 •
edited
Loading

Possible this is related to #937?

@zanieb
Copy link
Author

zanieb commented Jun 17, 2024

I've seen another failure at astral-sh/uv#4370 which is isolated from this upgrade. I'll report back if it ends up being related somehow.

@zanieb zanieb closed this as completed Jun 17, 2024
@zanieb
Copy link
Author

zanieb commented Jun 18, 2024

I can confirm this was caused by an increase in disk consumption causing a confusing error due to our GitHub Runner optimizations on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zanieb