Skip to content

Commit 1ec1567

Browse files
author
sfstar
authored
Merge pull request #211 from sfstar/feature/cleanup_device_seperation_obsolete_code
cleanup the device seperation obsolete code
2 parents db245cd + 10ffb1e commit 1ec1567

File tree

7 files changed

+0
-36
lines changed

7 files changed

+0
-36
lines changed

custom_components/victron/binary_sensor.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,6 @@ async def async_setup_entry(
4545
for register_name, registerInfo in register_info_dict[name].items():
4646
_LOGGER.debug("unit == " + str(slave) + " registerLedger == " + str(registerLedger) + " registerInfo ")
4747

48-
#VE.CAN device zero is present under unit 100. This seperates non system / settings entities into the seperate can device
49-
# if slave == 100 and not register_name.startswith(("settings", "system")) :
50-
# actual_id = 0
51-
# else:
52-
# actual_id = slave
53-
5448
if isinstance(registerInfo.entityType, BoolReadEntityType):
5549
description = VictronEntityDescription(
5650
key=register_name,

custom_components/victron/button.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,6 @@ async def async_setup_entry(
3939
if not config_entry.options[CONF_ADVANCED_OPTIONS]:
4040
continue
4141

42-
# if slave == 100 and not register_name.startswith(("settings", "system")) :
43-
# actual_id = 0
44-
# else:
45-
# actual_id = slave
46-
4742
if isinstance(registerInfo.entityType, ButtonWriteType):
4843
description = VictronEntityDescription(
4944
key=register_name,

custom_components/victron/hub.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,6 @@ def determine_present_devices(self):
6464
#VE.CAN device zero is present under unit 100. This seperates non system / settings entities into the seperate can device
6565
if unit == 100 and not key.startswith(("settings", "system")) :
6666
continue
67-
# actual_id = 0
68-
# else:
69-
# actual_id = unit
7067

7168
try:
7269
address = self.get_first_register_id(register_definition)

custom_components/victron/number.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,6 @@ async def async_setup_entry(
6363
for register_name, registerInfo in register_info_dict[name].items():
6464
_LOGGER.debug("unit == " + str(slave) + " registerLedger == " + str(registerLedger) + " registerInfo ")
6565

66-
# if slave == 100 and not register_name.startswith(("settings", "system")) :
67-
# actual_id = 0
68-
# else:
69-
# actual_id = slave
70-
7166
if isinstance(registerInfo.entityType, SliderWriteType):
7267
description = VictronEntityDescription(
7368
key=register_name,

custom_components/victron/select.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,6 @@ async def async_setup_entry(
4343
for register_name, registerInfo in register_info_dict[name].items():
4444
if isinstance(registerInfo.entityType, SelectWriteType):
4545
_LOGGER.debug("unit == " + str(slave) + " registerLedger == " + str(registerLedger) + " registerInfo ")
46-
47-
# if slave == 100 and not register_name.startswith(("settings", "system")) :
48-
# actual_id = 0
49-
# else:
50-
# actual_id = slave
5146

5247
description = VictronEntityDescription(
5348
key=register_name,

custom_components/victron/sensor.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,6 @@ async def async_setup_entry(
5656
if config_entry.options[CONF_ADVANCED_OPTIONS]:
5757
if not isinstance(registerInfo.entityType, ReadEntityType) or isinstance(registerInfo.entityType, BoolReadEntityType):
5858
continue
59-
60-
#VE.CAN device zero is present under unit 100. This seperates non system / settings entities into the seperate can device
61-
# if slave == 100 and not register_name.startswith(("settings", "system")) :
62-
# actual_id = 0
63-
# else:
64-
# actual_id = slave
6559

6660
description = VictronEntityDescription(
6761
key=register_name,

custom_components/victron/switch.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,6 @@ async def async_setup_entry(
3939
for register_name, registerInfo in register_info_dict[name].items():
4040
_LOGGER.debug("unit == " + str(slave) + " registerLedger == " + str(registerLedger) + " registerInfo ")
4141

42-
#VE.CAN device zero is present under unit 100. This seperates non system / settings entities into the seperate can device
43-
# if slave == 100 and not register_name.startswith(("settings", "system")) :
44-
# actual_id = 0
45-
# else:
46-
# actual_id = slave
47-
4842
if isinstance(registerInfo.entityType, SwitchWriteType):
4943
description = VictronEntityDescription(
5044
key=register_name,

0 commit comments

Comments
 (0)