Skip to content

Commit 3dbe004

Browse files
author
Sven ten Raa
committed
Also patch generator and battery registers with the fix of #7
1 parent 5dd18d7 commit 3dbe004

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

custom_components/victron/const.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -323,10 +323,10 @@ class vebus_error(Enum):
323323
"battery_info_maxchargecurrent": RegisterInfo(307, UINT16, ELECTRIC_CURRENT_AMPERE, 10),
324324
"battery_info_maxdischargecurrent": RegisterInfo(308, UINT16, ELECTRIC_CURRENT_AMPERE, 10),
325325
"battery_capacity": RegisterInfo(309, UINT16, ELECTRIC_CURRENT_AMPERE, 10),
326-
"battery_diagnostics_lasterror_1_time": RegisterInfo(310, INT32, "timestamp" ,1), #TODO check if decimal scale value is used here # extract timestamp
327-
"battery_diagnostics_lasterror_2_time": RegisterInfo(312, INT32, "timestamp" ,1), #TODO check if decimal scale value is used here # extract timestamp
328-
"battery_diagnostics_lasterror_3_time": RegisterInfo(314, INT32, "timestamp" ,1), #TODO check if decimal scale value is used here # extract timestamp
329-
"battery_diagnostics_lasterror_4_time": RegisterInfo(316, INT32, "timestamp" ,1), #TODO check if decimal scale value is used here # extract timestamp
326+
"battery_diagnostics_lasterror_1_time": RegisterInfo(310, INT32, "timestamp"),
327+
"battery_diagnostics_lasterror_2_time": RegisterInfo(312, INT32, "timestamp"),
328+
"battery_diagnostics_lasterror_3_time": RegisterInfo(314, INT32, "timestamp"),
329+
"battery_diagnostics_lasterror_4_time": RegisterInfo(316, INT32, "timestamp"),
330330
"battery_system_mincelltemperature": RegisterInfo(318, INT16, UnitOfTemperature.CELSIUS, 10),
331331
"battery_system_maxcelltemperature": RegisterInfo(319, INT16, UnitOfTemperature.CELSIUS, 10),
332332
"battery_alarm_higchargecurrent": RegisterInfo(register=320, dataType=UINT16, entityType=TextReadEntityType(generic_alarm_ledger)),
@@ -963,9 +963,9 @@ class generator_error(Enum):
963963
generator_registers = {
964964
"generator_manualstart": RegisterInfo(register=3500, dataType=UINT16, entityType=SwitchWriteType()),
965965
"generator_runningbyconditioncode": RegisterInfo(register=3501, dataType=UINT16, entityType=TextReadEntityType(generator_runningbyconditioncode)),
966-
"generator_runtime": RegisterInfo(3502, UINT16, TIME_SECONDS, 0), #documentation says 1 scale. assuming this is incorrect and 0 should be used like all other seconds registers
966+
"generator_runtime": RegisterInfo(3502, UINT16, TIME_SECONDS),
967967
"generator_quiethours": RegisterInfo(register=3503, dataType=UINT16, entityType=BoolReadEntityType()),
968-
"generator_runtime_2": RegisterInfo(3504, UINT32, TIME_SECONDS, 0),
968+
"generator_runtime_2": RegisterInfo(3504, UINT32, TIME_SECONDS),
969969
"generator_state": RegisterInfo(register=3506, dataType=UINT16, entityType=TextReadEntityType(generator_state)),
970970
"generator_error": RegisterInfo(register=3507, dataType=UINT16, entityType=TextReadEntityType(generator_error)),
971971
"generator_alarm_nogeneratoratacin": RegisterInfo(register=3508, dataType=UINT16, entityType=TextReadEntityType(generic_alarm_ledger)),

0 commit comments

Comments
 (0)