From 1565af51eacaad94081e1b802013d95d0e0abe7e Mon Sep 17 00:00:00 2001 From: sfstar Date: Sun, 16 Nov 2025 22:31:01 +0000 Subject: [PATCH 1/2] remove 3 of the new registers since they seem to report garbage values --- custom_components/victron/const.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/custom_components/victron/const.py b/custom_components/victron/const.py index d938a15..62808f0 100644 --- a/custom_components/victron/const.py +++ b/custom_components/victron/const.py @@ -923,7 +923,8 @@ class battery_mode(Enum): dataType=UINT16, entityType=TextReadEntityType(generic_alarm_ledger), ), - "battery_mode": RegisterInfo(327, UINT16, entityType=SelectWriteType(battery_mode)), + # disabled for now as it is specified as RESERVED (not yet active) in the documentation + # "battery_mode": RegisterInfo(327, UINT16, entityType=SelectWriteType(battery_mode)), } battery_registers_2 = { @@ -997,7 +998,6 @@ class battery_error(Enum): class battery_mode_alternative(Enum): """Battery mode alternative.""" - ON = 3 STANDBY = 252 @@ -1073,9 +1073,9 @@ class battery_balancer_status(Enum): } battery_info_registers = { - "battery_mode_2": RegisterInfo( - 1319, UINT16, entityType=SelectWriteType(battery_mode_alternative) - ), + # "battery_mode_2": RegisterInfo( + # 1319, UINT16, entityType=SelectWriteType(battery_mode_alternative) + # ), "battery_balancer_status": RegisterInfo( 1320, UINT16, entityType=TextReadEntityType(battery_balancer_status) ), @@ -1094,7 +1094,7 @@ class battery_balancer_status(Enum): "battery_errors_smartlithium_invalidconfiguration": RegisterInfo( 1324, UINT16 ), # This has no decode values for returned numbers - "battery_connection_information": RegisterInfo(1328, STRING(8)), + # "battery_connection_information": RegisterInfo(1328, STRING(8)), } @@ -3672,5 +3672,4 @@ class system_battery_state(Enum): "system_invertercharger_registers": system_invertercharger_registers, "system_pvac_registers": system_pvac_registers, "system_power_registers_2": system_power_registers_2, - } From 7ebbc99489bd1ea8987bbadb010b5d2529def630 Mon Sep 17 00:00:00 2001 From: sfstar Date: Sun, 16 Nov 2025 22:44:19 +0000 Subject: [PATCH 2/2] fix ruff findings --- custom_components/victron/const.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/custom_components/victron/const.py b/custom_components/victron/const.py index 62808f0..dbe13c5 100644 --- a/custom_components/victron/const.py +++ b/custom_components/victron/const.py @@ -998,6 +998,7 @@ class battery_error(Enum): class battery_mode_alternative(Enum): """Battery mode alternative.""" + ON = 3 STANDBY = 252 @@ -1073,9 +1074,9 @@ class battery_balancer_status(Enum): } battery_info_registers = { - # "battery_mode_2": RegisterInfo( - # 1319, UINT16, entityType=SelectWriteType(battery_mode_alternative) - # ), + # "battery_mode_2": RegisterInfo( + # 1319, UINT16, entityType=SelectWriteType(battery_mode_alternative) + # ), "battery_balancer_status": RegisterInfo( 1320, UINT16, entityType=TextReadEntityType(battery_balancer_status) ),