Adds unwrap on try_push for Vec<String>

auyer · auyer · commit 385e602dc282 · 2023-04-18T13:12:37.000-03:00
If it fails, the resulting Chunks will have wrong size

With unwrap the failure wont be so silent.

Failure without unwrap:
_read_sql(
RuntimeError: Invalid argument error: Chunk require all its arrays to have an equal number of rows
diff --git a/connectorx/src/destinations/arrow2/arrow_assoc.rs b/connectorx/src/destinations/arrow2/arrow_assoc.rs
@@ -480,7 +480,7 @@ impl ArrowAssoc for Vec<String> {
         for sub_value in value {
             string_array.push(Some(sub_value))
         }
-        builder.try_push(Some(string_array));
+        builder.try_push(Some(string_array)).unwrap();
     }
 
     fn field(header: &str) -> Field {

Original file line number	Diff line number	Diff line change
`@@ -480,7 +480,7 @@ impl ArrowAssoc for Vec<String> {`
`480`	`480`	`for sub_value in value {`
`481`	`481`	`string_array.push(Some(sub_value))`
`482`	`482`	`}`
`483`		`- builder.try_push(Some(string_array));`
	`483`	`+ builder.try_push(Some(string_array)).unwrap();`
`484`	`484`	`}`
`485`	`485`
`486`	`486`	`fn field(header: &str) -> Field {`