-
Notifications
You must be signed in to change notification settings - Fork 35
Setup air speed velocity for micro benchmarks #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Reopening, as the benchmark suite has not had a successful run yet. |
This is quite weird, this works on my personal and organization accounts: https://github.com/AktechLabs/sgkit/runs/2111770945?check_suite_focus=true @hammer Can you confirm the following.
|
I added it to the |
Oh, I see. The token needs to be in this repo: pystatgen/sgkit |
Okay, try now? |
I don't have the access to rerun a workflow. Can one of you rerun this workflow? |
I just reran it @aktech, can you have a look and see if it succeeded? |
Yes, it did succeed. Thanks @hammer and @jeromekelleher Now, there is one last thing that needs to be done for the benchmarks to be visible on the Github pages on this link: http://pystatgen.github.io/sgkit-benchmarks-asv/
This is how the Github Pages section would look like, after the above steps: |
Done! Thanks for the guide @aktech |
@tomwhite, I guess we should confirm a few uploads of benchmarks before closing? |
Thanks! the benchmarks are live now: https://pystatgen.github.io/sgkit-benchmarks-asv/ |
Looks good. Thanks for doing this @aktech. Would it be possible to add a badge to the README with a link to the benchmarks? |
Yeah, sure. Can someone add this link: https://pystatgen.github.io/sgkit-benchmarks-asv/ |
Done! |
Closing this issue as discussed on the call today. Thanks @aktech! |
As discussed in the developer call it would be good to have some kind of benchmarking. Air speed velocity is a good tool for micro benchmarks: https://asv.readthedocs.io/en/stable/ as suggested.
Setting this up and throwing the artefacts somewhere will enable us to see the benchmarks over time like this:
https://pv.github.io/numpy-bench/
cc @jeromekelleher
The text was updated successfully, but these errors were encountered: