Skip to content

Setup air speed velocity for micro benchmarks #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aktech opened this issue Feb 5, 2021 · 16 comments · Fixed by #466
Closed

Setup air speed velocity for micro benchmarks #458

aktech opened this issue Feb 5, 2021 · 16 comments · Fixed by #466
Assignees

Comments

@aktech
Copy link
Contributor

aktech commented Feb 5, 2021

As discussed in the developer call it would be good to have some kind of benchmarking. Air speed velocity is a good tool for micro benchmarks: https://asv.readthedocs.io/en/stable/ as suggested.

Setting this up and throwing the artefacts somewhere will enable us to see the benchmarks over time like this:
https://pv.github.io/numpy-bench/

cc @jeromekelleher

@jeromekelleher
Copy link
Collaborator

See also #68 - should we mark this issue as a dupe @hammer, or keep it as more specific?

@tomwhite
Copy link
Collaborator

Reopening, as the benchmark suite has not had a successful run yet.

@tomwhite tomwhite reopened this Mar 15, 2021
@aktech
Copy link
Contributor Author

aktech commented Mar 15, 2021

This is quite weird, this works on my personal and organization accounts:

https://github.com/AktechLabs/sgkit/runs/2111770945?check_suite_focus=true
https://github.com/aktech/sgkit/runs/2039205063?check_suite_focus=true

@hammer Can you confirm the following.

  1. This is how the access token scope looks like:

Screenshot 2021-03-15 at 11 36 59

  1. You added the token named GH_TOKEN, in this (pystatgen/sgkit) repository.
  2. You have push access to pystatgen/sgkit-benchmarks-asv repository.

@hammer
Copy link
Contributor

hammer commented Mar 15, 2021

I added it to the pystatgen/sgkit-benchmarks-asv repo. Is that not right?

@aktech
Copy link
Contributor Author

aktech commented Mar 15, 2021

I added it to the pystatgen/sgkit-benchmarks-asv repo. Is that not right?

Oh, I see. The token needs to be in this repo: pystatgen/sgkit
Apologies, the instructions I sent probably did not stated the repo name explicitly.

@hammer hammer self-assigned this Mar 15, 2021
@hammer
Copy link
Contributor

hammer commented Mar 15, 2021

Okay, try now?

@aktech
Copy link
Contributor Author

aktech commented Mar 15, 2021

I don't have the access to rerun a workflow. Can one of you rerun this workflow?
https://github.com/pystatgen/sgkit/runs/2114712818

Screenshot 2021-03-15 at 21 40 17

@jeromekelleher
Copy link
Collaborator

I just reran it @aktech, can you have a look and see if it succeeded?

@aktech
Copy link
Contributor Author

aktech commented Mar 16, 2021

Yes, it did succeed. Thanks @hammer and @jeromekelleher

Now, there is one last thing that needs to be done for the benchmarks to be visible on the Github pages on this link: http://pystatgen.github.io/sgkit-benchmarks-asv/

  1. Go to https://github.com/pystatgen/sgkit-benchmarks-asv/settings
  2. In the Github Pages section, select the source branch to be main and
  3. Check the Enforce HTTPS button

This is how the Github Pages section would look like, after the above steps:

Screenshot 2021-03-16 at 07 10 21

@jeromekelleher
Copy link
Collaborator

Done! Thanks for the guide @aktech

@jeromekelleher
Copy link
Collaborator

@tomwhite, I guess we should confirm a few uploads of benchmarks before closing?

@aktech
Copy link
Contributor Author

aktech commented Mar 16, 2021

Thanks! the benchmarks are live now: https://pystatgen.github.io/sgkit-benchmarks-asv/

@tomwhite
Copy link
Collaborator

Looks good. Thanks for doing this @aktech. Would it be possible to add a badge to the README with a link to the benchmarks?

@aktech
Copy link
Contributor Author

aktech commented Mar 17, 2021

Looks good. Thanks for doing this @aktech. Would it be possible to add a badge to the README with a link to the benchmarks?

Yeah, sure.

Can someone add this link: https://pystatgen.github.io/sgkit-benchmarks-asv/
In the about section of https://github.com/pystatgen/sgkit-benchmarks-asv as well

Screenshot 2021-03-17 at 09 37 28

@hammer
Copy link
Contributor

hammer commented Mar 17, 2021

Can someone add this link: https://pystatgen.github.io/sgkit-benchmarks-asv/
In the about section of https://github.com/pystatgen/sgkit-benchmarks-asv as well

Done!

@hammer
Copy link
Contributor

hammer commented Mar 18, 2021

Closing this issue as discussed on the call today. Thanks @aktech!

@hammer hammer closed this as completed Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants