Skip to content

Commit 4319978

Browse files
authored
Fix data parallel perf regression (#6183)
1 parent 03dd785 commit 4319978

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

.github/workflows/execute-notebook.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,6 @@ jobs:
2222
- name: Checkout code
2323
uses: actions/checkout@v4
2424

25-
- name: Set up Python
26-
uses: actions/setup-python@v4
27-
with:
28-
python-version: '3.9'
29-
3025
- name: Install dependencies
3126
run: |
3227
bash scripts/ci_install_dependency.sh
@@ -35,6 +30,8 @@ jobs:
3530
apt-get install -y pandoc
3631
apt-get update && apt-get install -y parallel retry
3732
33+
ln -sf "$(which python3)" /usr/bin/python
34+
3835
- name: Setup Jupyter Kernel
3936
run: |
4037
python -m ipykernel install --user --name python3 --display-name "Python 3"

python/sglang/srt/managers/data_parallel_controller.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@
1717
import multiprocessing as mp
1818
import signal
1919
import threading
20+
import time
2021
from enum import Enum, auto
2122

2223
import psutil
2324
import setproctitle
2425
import zmq
2526

26-
from sglang.srt.disaggregation.utils import DisaggregationMode
2727
from sglang.srt.layers.dp_attention import compute_dp_attention_world_info
2828
from sglang.srt.managers.io_struct import (
2929
TokenizedEmbeddingReqInput,
@@ -158,7 +158,7 @@ def launch_tensor_parallel_group_thread(
158158
# This thread cannot be closed because otherwise the `kill_itself_when_parent_died`
159159
# function in scheduler.py will kill the scheduler.
160160
while True:
161-
pass
161+
time.sleep(30 * 24 * 3600)
162162

163163
def launch_dp_attention_schedulers(self, server_args, port_args):
164164
self.launch_tensor_parallel_group(server_args, port_args, 0, None)

0 commit comments

Comments
 (0)