Skip to content

PHP 8.x Incompatibility with Calendar Module #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Silarn opened this issue May 23, 2022 · 3 comments
Closed

PHP 8.x Incompatibility with Calendar Module #116

Silarn opened this issue May 23, 2022 · 3 comments

Comments

@Silarn
Copy link

Silarn commented May 23, 2022

It wasn't clear to me where to report this since there doesn't seem to be a publicly accessible issue tracker.

The shipperhq/module-calendar package has an issue in Model/CalendarConfigProvider.php on line 115 as you can no longer pass a non-string value into strstr(). A null coalesce should fix it.

@WSAlewis
Copy link

Hello @Silarn,

Thanks for reaching out to us.

Currently, the Calendar module is not compatible with PHP 8.1, and Magento 2.4.4.

Our QA team is testing the latest unreleased update of this module which will provide support for the version mentioned above. We're expecting that this update to be available by the end of this week.

  • Lewis, Technical Support Engineer at ShipperHQ

@n2diving-dgx
Copy link

Confirm issue with calendar module and PHP 8.1

This is causing shipperHQ to error out and can't see shipping options in shopping cart or anything at all when attempting to checkout.

[2022-05-24T16:17:04.278670+00:00] main.CRITICAL: Exception: Deprecated Functionality: strstr(): Passing null to parameter #1 ($haystack) of type string is deprecated in /home/divegearexpress/www/releases/20220524151246/vendor/shipperhq/module-calendar/src/Model/CalendarConfigProvider.php on line 115 in /home/divegearexpress/www/releases/20220524151246/vendor/magento/framework/App/ErrorHandler.php:61

@wsajosh
Copy link
Contributor

wsajosh commented Aug 9, 2022

Hi,

Thanks for your patience. As of the end of May, all ShipperHQ modules are compatible with Magento 2.4.4 and PHP8.1.

@wsajosh wsajosh closed this as completed Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants