Skip to content

Incorrect data type provided for freight_class attribute #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xaevik opened this issue Nov 25, 2022 · 2 comments
Closed

Incorrect data type provided for freight_class attribute #127

xaevik opened this issue Nov 25, 2022 · 2 comments

Comments

@xaevik
Copy link

xaevik commented Nov 25, 2022

We began experiencing an issue with order exports failing due to an implicit cast conversion deprecation being thrown. Upon investigation it was revealed that freight_class has an incorrect data type defined:

$catalogSetup->addAttribute(Product::ENTITY, 'freight_class', [
'type' => 'int',

It should be decimal not int as there are numerous freight classes (e.g., 77.5) that cannot be treated as integers.

Edit: string might be a better option if a numeric primitive is not really needed.

We have patched our environments in the interim until this issue is fixed in upstream.

@shqsupport
Copy link

Hi @xaevik ,

Thank you for contacting us regarding this issue. Our development team will be looking into the freight_class data type.

Have a great day,
Peter

@wsajosh
Copy link
Contributor

wsajosh commented Jan 30, 2023

Hi @xaevik

Thanks for raising this. I've just released a new version of the extension which corrects this issue. Please update when you can.

@wsajosh wsajosh closed this as completed Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants