Merge pull request #69 from shotgunsoftware/25648-adjust-update-project-last-accessed-by-current-user

For #25648 pull out work now done server-side

Author: Neil Brandt

shotgun_api3/shotgun.py

@@ -1446,31 +1446,24 @@ def update_project_last_accessed(self, project, user=None):
         :param user - A human user entity hash. Optional if either login or sudo_as are used.
 
         """
-        if self.server_caps.version and self.server_caps.version < (5, 3, 17):
-                raise ShotgunError("update_project_last_accessed requires server version 5.3.17 or "\
+        if self.server_caps.version and self.server_caps.version < (5, 3, 20):
+                raise ShotgunError("update_project_last_accessed requires server version 5.3.20 or "\
                     "higher, server is %s" % (self.server_caps.version,))
 
-        # Find a page from the project
-        page = self.find_one('Page', [['project','is',project], ['ui_category','is','project_overview']])
-        if not page:
-            # There should be a project overview page page for a live project, but if there is not,
-            # another page from the project will work.
-            page = self.find_one('Page', [['project','is',project]])
-
-        if not page:
-            raise RuntimeError("Unable to find page for project %s" % str(project))
-
         if not user:
             # Try to use sudo as user if present
             if self.config.sudo_as_login:
                 user = self.find_one('HumanUser', [['login', 'is', self.config.sudo_as_login]])
             # Try to use login if present
             if self.config.user_login:
                 user = self.find_one('HumanUser', [['login', 'is', self.config.user_login]])
-        if not user:
-            raise RuntimeError("No user supplied and unable to determine user from login or sudo_as")
 
-        self.create( 'PageHit', { 'page': page, 'user': user } )
+        params = { "project_id": project['id'], }
+        if user:
+            params['user_id'] = user['id']
+
+        record = self._call_rpc("update_project_last_accessed_by_current_user", params)
+        result = self._parse_records(record)[0]
 
 
     def _get_session_token(self):

tests/test_api.py

@@ -1562,7 +1562,7 @@ def test_humanuser_upload_thumbnail_for_version(self):
 class TestProjectLastAccessedByCurrentUser(base.LiveTestBase):
     # Ticket #24681
     def test_logged_in_user(self):
-        if self.sg.server_caps.version and self.sg.server_caps.version < (5, 3, 17):
+        if self.sg.server_caps.version and self.sg.server_caps.version < (5, 3, 20):
             return
 
         sg = shotgun_api3.Shotgun(self.config.server_url,
@@ -1582,7 +1582,7 @@ def test_logged_in_user(self):
 
 
     def test_pass_in_user(self):
-        if self.sg.server_caps.version and self.sg.server_caps.version < (5, 3, 17):
+        if self.sg.server_caps.version and self.sg.server_caps.version < (5, 3, 20):
             return
 
         sg = shotgun_api3.Shotgun( self.config.server_url,
@@ -1603,7 +1603,7 @@ def test_pass_in_user(self):
             assert(initial['last_accessed_by_current_user'] < current['last_accessed_by_current_user'])
 
     def test_sudo_as_user(self):
-        if self.sg.server_caps.version and self.sg.server_caps.version < (5, 3, 17):
+        if self.sg.server_caps.version and self.sg.server_caps.version < (5, 3, 20):
             return
 
         sg = shotgun_api3.Shotgun( self.config.server_url,