use BestCompression level for gzip writer

silverwind · web-flow · commit 0d455de96546 · 2020-08-24T01:29:19.000-04:00
In the context of vfsgen, it should be a favorable trade-off to spend more time and effort when performing file compression, if it can lead to file sizes being reduced further. The previous choice of compression level (DefaultCompression) was inherited from this project's go-bindata lineage. Fixes #85. GitHub-Pull-Request: #86
diff --git a/generator.go b/generator.go
@@ -170,7 +170,7 @@ func writeCompressedFileInfo(w io.Writer, file *fileInfo, r io.Reader) error {
 		return err
 	}
 	sw := &stringWriter{Writer: w}
-	gw := gzip.NewWriter(sw)
+	gw, _ := gzip.NewWriterLevel(sw, gzip.BestCompression)
 	_, err = io.Copy(gw, r)
 	if err != nil {
 		return err
diff --git a/test/test_test.go b/test/test_test.go
@@ -114,7 +114,7 @@ func Example_compressed() {
 	// <not compressed>
 	// /sample-file.txt
 	// "This file compresses well. Blaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaah!" <nil>
-	// "\x1f\x8b\b\x00\x00\x00\x00\x00\x00\xff\n\xc9\xc8,VH\xcb\xccIUH\xce\xcf-(J-.N-V(O\xcd\xc9\xd1Sp\xcaI\x1c\xd4 C\x11\x10\x00\x00\xff\xff\xe7G\x81:\xbd\x00\x00\x00"
+	// "\x1f\x8b\b\x00\x00\x00\x00\x00\x02\xff\n\xc9\xc8,VH\xcb\xccIUH\xce\xcf-(J-.N-V(O\xcd\xc9\xd1Sp\xcaI\x1c\xd4 C\x11\x10\x00\x00\xff\xff\xe7G\x81:\xbd\x00\x00\x00"
 }
 
 func Example_readTwoOpenedCompressedFiles() {
diff --git a/test/test_vfsdata_test.go b/test/test_vfsdata_test.go

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ func writeCompressedFileInfo(w io.Writer, file *fileInfo, r io.Reader) error {`
`170`	`170`	`return err`
`171`	`171`	`}`
`172`	`172`	`sw := &stringWriter{Writer: w}`
`173`		`- gw := gzip.NewWriter(sw)`
	`173`	`+ gw, _ := gzip.NewWriterLevel(sw, gzip.BestCompression)`
`174`	`174`	`_, err = io.Copy(gw, r)`
`175`	`175`	`if err != nil {`
`176`	`176`	`return err`
Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ func Example_compressed() {`
`114`	`114`	`// <not compressed>`
`115`	`115`	`// /sample-file.txt`
`116`	`116`	`// "This file compresses well. Blaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaah!" <nil>`
`117`		`- // "\x1f\x8b\b\x00\x00\x00\x00\x00\x00\xff\n\xc9\xc8,VH\xcb\xccIUH\xce\xcf-(J-.N-V(O\xcd\xc9\xd1Sp\xcaI\x1c\xd4 C\x11\x10\x00\x00\xff\xff\xe7G\x81:\xbd\x00\x00\x00"`
	`117`	`+ // "\x1f\x8b\b\x00\x00\x00\x00\x00\x02\xff\n\xc9\xc8,VH\xcb\xccIUH\xce\xcf-(J-.N-V(O\xcd\xc9\xd1Sp\xcaI\x1c\xd4 C\x11\x10\x00\x00\xff\xff\xe7G\x81:\xbd\x00\x00\x00"`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`func Example_readTwoOpenedCompressedFiles() {`