Merge pull request #1666 from tommarien/fix/emit-end-if-stream-receives-end

fix(connection): ensure pooled connections get released

Author: sidorares

lib/connection.js

@@ -96,6 +96,10 @@ class Connection extends EventEmitter {
       }
       this.packetParser.execute(data);
     });
+    this.stream.on('end', () => {
+      // emit the end event so that the pooled connection can close the connection
+      this.emit('end');
+    });
     this.stream.on('close', () => {
       // we need to set this flag everywhere where we want connection to close
       if (this._closing) {

test/integration/test-pool-end.js

@@ -0,0 +1,22 @@
+'use strict';
+
+const { createPool } = require('../common.js');
+const assert = require('assert');
+
+const pool = createPool();
+
+pool.getConnection((err, conn) => {
+  assert.ifError(err);
+
+  assert(pool._allConnections.length === 1);
+  assert(pool._freeConnections.length === 0);
+
+  // emit the end event, so the connection gets removed from the pool
+  conn.stream.emit('end');
+
+  assert(pool._allConnections.length === 0);
+  assert(pool._freeConnections.length === 0);
+
+  // As the connection has not really ended we need to do this ourselves
+  conn.destroy();
+});