Skip to content

Commit 639a921

Browse files
committed
Remove/document remaining Electra TODOs
1 parent 0728140 commit 639a921

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

beacon_node/execution_layer/src/lib.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,7 @@ pub enum BlockProposalContents<E: EthSpec, Payload: AbstractExecPayload<E>> {
209209
/// `None` for blinded `PayloadAndBlobs`.
210210
blobs_and_proofs: Option<(BlobsList<E>, KzgProofs<E>)>,
211211
// TODO(electra): this should probably be a separate variant/superstruct
212+
// See: https://github.com/sigp/lighthouse/issues/6981
212213
requests: Option<ExecutionRequests<E>>,
213214
},
214215
}

consensus/state_processing/src/genesis.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,7 @@ pub fn initialize_beacon_state_from_eth1<E: EthSpec>(
123123
// Remove intermediate Deneb fork from `state.fork`.
124124
state.fork_mut().previous_version = spec.electra_fork_version;
125125

126-
// TODO(electra): think about this more and determine the best way to
127-
// do this. The spec tests will expect that the sync committees are
126+
// The spec tests will expect that the sync committees are
128127
// calculated using the electra value for MAX_EFFECTIVE_BALANCE when
129128
// calling `initialize_beacon_state_from_eth1()`. But the sync committees
130129
// are actually calcuated back in `upgrade_to_altair()`. We need to

consensus/state_processing/src/per_block_processing/verify_attestation.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ pub fn verify_attestation_for_state<'ctxt, E: EthSpec>(
6363
) -> Result<IndexedAttestationRef<'ctxt, E>> {
6464
let data = attestation.data();
6565

66-
// TODO(electra) choosing a validation based on the attestation's fork
66+
// NOTE: choosing a validation based on the attestation's fork
6767
// rather than the state's fork makes this simple, but technically the spec
6868
// defines this verification based on the state's fork.
6969
match attestation {

consensus/types/src/validator.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,6 @@ impl Validator {
249249
}
250250
}
251251

252-
/// TODO(electra): refactor these functions and make it simpler.. this is a mess
253252
/// Returns `true` if the validator is partially withdrawable.
254253
fn is_partially_withdrawable_validator_capella(&self, balance: u64, spec: &ChainSpec) -> bool {
255254
self.has_eth1_withdrawal_credential(spec)

0 commit comments

Comments
 (0)