Skip to content

Commit fe04993

Browse files
authored
Drop conditional when verifying entry checkpoint (#1917)
The log has been returning checkpoints for over a year now. Additionally, there should be no persisted bundles where the inclusion proof does not include a checkpoint, because it was marked as a required field from its inception. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
1 parent 9b0805b commit fe04993

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

pkg/verify/verify.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -220,13 +220,9 @@ func VerifyLogEntry(ctx context.Context, e *models.LogEntryAnon, verifier signat
220220
return err
221221
}
222222

223-
// TODO: Add support for verifying consistency against an optional provided checkpoint.
224-
// See https://github.com/sigstore/rekor/issues/988
225-
// TODO: Remove conditional once checkpoint is always returned by server.
226-
if e.Verification.InclusionProof.Checkpoint != nil {
227-
if err := VerifyCheckpointSignature(e, verifier); err != nil {
228-
return err
229-
}
223+
// Verify checkpoint, which includes a signed root hash.
224+
if err := VerifyCheckpointSignature(e, verifier); err != nil {
225+
return err
230226
}
231227

232228
// Verify the Signed Entry Timestamp.

0 commit comments

Comments
 (0)