Merge pull request #47 from sile/fix-issue43

Ignore ERROR_SHARING_VIOLATION (Windows) error when file rotation

Author: sile

src/file.rs

@@ -276,6 +276,28 @@ impl FileAppender {
 
         let _ = self.file.take();
 
+        #[cfg(windows)]
+        {
+            if let Err(err) = self.rotate_old_files() {
+                const ERROR_SHARING_VIOLATION: i32 = 32;
+
+                // To avoid the problem reported by https://github.com/sile/sloggers/issues/43,
+                // we ignore the error if its code is 32.
+                if err.raw_os_error() != Some(ERROR_SHARING_VIOLATION) {
+                    return Err(err);
+                }
+            }
+        }
+        #[cfg(not(windows))]
+        self.rotate_old_files()?;
+
+        self.written_size = 0;
+        self.next_reopen_check = Instant::now();
+        self.reopen_if_needed()?;
+
+        Ok(())
+    }
+    fn rotate_old_files(&mut self) -> io::Result<()> {
         for i in (1..=self.rotate_keep).rev() {
             let from = self.rotated_path(i)?;
             let to = self.rotated_path(i + 1)?;
@@ -311,10 +333,6 @@ impl FileAppender {
             fs::remove_file(delete_path)?;
         }
 
-        self.written_size = 0;
-        self.next_reopen_check = Instant::now();
-        self.reopen_if_needed()?;
-
         Ok(())
     }
     fn rotated_path(&self, i: usize) -> io::Result<PathBuf> {
@@ -527,9 +545,9 @@ fn path_template_to_path(
     let timestamp_string = match timezone {
         TimeZone::Local => {
             let local_timestamp = Local.from_utc_datetime(&date_time.naive_utc());
-            local_timestamp.format(&timestamp_template)
+            local_timestamp.format(timestamp_template)
         }
-        TimeZone::Utc => date_time.format(&timestamp_template),
+        TimeZone::Utc => date_time.format(timestamp_template),
     }
     .to_string();
     let path_string = path_template.replace("{timestamp}", &timestamp_string);

src/syslog/format.rs

@@ -160,7 +160,7 @@ impl<W: fmt::Write> fmt::Write for Rfc5424LikeValueEscaper<W> {
             if s.len() >= index {
                 s = &s[(index + 1)..];
             } else {
-                s = &"";
+                s = "";
                 break;
             }
         }