Skip to content

Commit a15eec8

Browse files
committed
[Fix] no-unknown-property: Only match data attributes containing -
Fixes: jsx-eslint#3712
1 parent da1013c commit a15eec8

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

lib/rules/no-unknown-property.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ function normalizeAttributeCase(name) {
431431
* @returns {boolean} Result
432432
*/
433433
function isValidDataAttribute(name) {
434-
return !/^data-xml/i.test(name) && /^data(-?[^:]*)$/.test(name);
434+
return !/^data-xml/i.test(name) && /^data-[^:]*$/.test(name);
435435
}
436436

437437
/**

tests/lib/rules/no-unknown-property.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,7 @@ ruleTester.run('no-unknown-property', rule, {
603603
],
604604
},
605605
{
606-
code: '<div data-testID="bar" data-under_sCoRe="bar" />;',
606+
code: '<div data-testID="bar" data-under_sCoRe="bar" dataNotAttribute="yes" />;',
607607
errors: [
608608
{
609609
messageId: 'dataLowercaseRequired',
@@ -619,6 +619,13 @@ ruleTester.run('no-unknown-property', rule, {
619619
lowerCaseName: 'data-under_score',
620620
},
621621
},
622+
{
623+
messageId: 'unknownProp',
624+
data: {
625+
name: 'dataNotAttribute',
626+
lowerCaseName: 'datanotattribute',
627+
},
628+
},
622629
],
623630
options: [{ requireDataLowercase: true }],
624631
},

0 commit comments

Comments
 (0)