Require Node.js 8

Author: sindresorhus

.gitattributes

@@ -1,2 +1 @@
-* text=auto
-*.js text eol=lf
+* text=auto eol=lf

.travis.yml

@@ -1,4 +1,4 @@
 language: node_js
 node_js:
+  - '10'
   - '8'
-  - '6'

index.js

@@ -6,32 +6,16 @@ module.exports = class AddAssetPlugin {
 		this.source = source;
 	}
 
-	// TODO: For when we target Node.js 8
-	// apply(compiler) {
-	// 	compiler.plugin('emit', async (compilation, cb) => {
-	// 		const source = typeof this.source === 'string' ? this.source : await this.source(compilation);
-
-	// 		compilation.assets[this.filePath] = {
-	// 			source: () => source,
-	// 			size: () => source.length
-	// 		};
-
-	// 		cb();
-	// 	});
-	// }
-
 	apply(compiler) {
-		compiler.plugin('emit', (compilation, cb) => {
-			const rawSource = typeof this.source === 'string' ? this.source : this.source(compilation);
+		compiler.plugin('emit', async (compilation, callback) => {
+			const source = typeof this.source === 'string' ? this.source : await this.source(compilation);
 
-			Promise.resolve(rawSource).then(source => {
-				compilation.assets[this.filePath] = {
-					source: () => source,
-					size: () => source.length
-				};
+			compilation.assets[this.filePath] = {
+				source: () => source,
+				size: () => source.length
+			};
 
-				cb();
-			});
+			callback();
 		});
 	}
 };

package.json

@@ -1,38 +1,38 @@
 {
-  "name": "add-asset-webpack-plugin",
-  "version": "0.1.0",
-  "description": "Dynamically add an asset to the webpack graph",
-  "license": "MIT",
-  "repository": "sindresorhus/add-asset-webpack-plugin",
-  "author": {
-    "name": "Sindre Sorhus",
-    "email": "[email protected]",
-    "url": "sindresorhus.com"
-  },
-  "engines": {
-    "node": ">=6"
-  },
-  "scripts": {
-    "test": "xo && ava"
-  },
-  "files": [
-    "index.js"
-  ],
-  "keywords": [
-    "webpack-plugin",
-    "webpack",
-    "add",
-    "generate",
-    "create",
-    "make",
-    "asset",
-    "file"
-  ],
-  "devDependencies": {
-    "ava": "*",
-    "pify": "^3.0.0",
-    "tempy": "^0.2.1",
-    "webpack": "^3.10.0",
-    "xo": "*"
-  }
+	"name": "add-asset-webpack-plugin",
+	"version": "0.1.0",
+	"description": "Dynamically add an asset to the webpack graph",
+	"license": "MIT",
+	"repository": "sindresorhus/add-asset-webpack-plugin",
+	"author": {
+		"name": "Sindre Sorhus",
+		"email": "[email protected]",
+		"url": "sindresorhus.com"
+	},
+	"engines": {
+		"node": ">=8"
+	},
+	"scripts": {
+		"test": "xo && ava"
+	},
+	"files": [
+		"index.js"
+	],
+	"keywords": [
+		"webpack-plugin",
+		"webpack",
+		"add",
+		"generate",
+		"create",
+		"make",
+		"asset",
+		"file"
+	],
+	"devDependencies": {
+		"ava": "^1.3.1",
+		"pify": "^4.0.1",
+		"tempy": "^0.2.1",
+		"webpack": "^4.29.6",
+		"xo": "^0.24.0"
+	}
 }

readme.md

@@ -38,7 +38,7 @@ Relative file path for the asset.
 
 #### source
 
-Type: `string` `Function<string|Promise>`
+Type: `string` `Function => string | Promise<string>`
 
 Asset source or a function that returns the asset source.
 

test.js

@@ -5,7 +5,7 @@ import webpack from 'webpack';
 import tempy from 'tempy';
 import pify from 'pify';
 
-test(async t => {
+test('main', async t => {
 	const config = require('./fixture/webpack.config');
 	const cwd = tempy.directory();
 	config.output.path = cwd;