Skip to content

Add a config file. #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamestalmage opened this issue Jan 4, 2016 · 9 comments
Closed

Add a config file. #405

jamestalmage opened this issue Jan 4, 2016 · 9 comments
Assignees

Comments

@jamestalmage
Copy link
Contributor

Probably just an ava section in package.json.

The available options are getting complex enough that I think we are close to needing this (if we aren't there already).

{
  "serial": true,
  "verbose": true,
  "cache": false
}

These would need to be merged with whatever is specified on the command line (command line taking precedence).

The goal is to be able to specify the default way you want it to behave when you simply type ava on the command line.

@sindresorhus
Copy link
Member

👍 I do that with XO too. I would prefer only a section in package.json. Makes things simple.

https://github.com/sindresorhus/pkg-conf

@ariporad
Copy link
Contributor

ariporad commented Jan 4, 2016

Agreed. I'd also like to add a "files" section, and have it be "config.ava", vs. "ava "

@sindresorhus
Copy link
Member

I'd also like to add a "files" section

👍

and have it be "config.ava", vs. "ava "

👎 That's a convention nobody uses. Top-level is simpler and it will never conflict with anything anyways.

@jamestalmage
Copy link
Contributor Author

That's a convention nobody uses

Except for istanbuljs/nyc#131 😄

@jamestalmage
Copy link
Contributor Author

I'd also like to add a "files" section

Yeah, I think basically any config value is fair game. I can't think of one we shouldn't allow them to configure this way.

@vadimdemedes
Copy link
Contributor

Great suggestion, I'm on board!

@jamestalmage jamestalmage self-assigned this Jan 4, 2016
jamestalmage added a commit to jamestalmage/ava that referenced this issue Jan 4, 2016
jamestalmage added a commit to jamestalmage/ava that referenced this issue Jan 4, 2016
jamestalmage added a commit to jamestalmage/ava that referenced this issue Jan 4, 2016
jamestalmage added a commit to jamestalmage/ava that referenced this issue Jan 4, 2016
@ariporad
Copy link
Contributor

ariporad commented Jan 4, 2016

@sindresorhus: Except nyc and comitizen (off the top of my head).

@jamestalmage
Copy link
Contributor Author

nyc is falling off that list very soon: istanbuljs/nyc#132

@kentcdodds
Copy link
Contributor

Add ghooks to the list of modules that use the config convention :-) But meh, it'll never conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants