Fix --dry-run behavior and clarify help text

Author: sindresorhus

cli.js

@@ -17,7 +17,7 @@ const cli = meow(`
 
 	Options
 	  --force, -f    Allow deleting the current working directory and outside
-	  --dry-run, -d  List what would be deleted instead of deleting
+	  --dry-run, -d  List what would be deleted instead of deleting (silent if no matches)
 	  --verbose, -v  Display the absolute path of files and directories as they are deleted
 
 	Examples
@@ -45,13 +45,15 @@ if (cli.input.length === 0) {
 	console.error('Specify at least one path');
 	process.exitCode = 1;
 } else {
-	const {verbose, ...flags} = cli.flags;
+	const {verbose, dryRun, ...flags} = cli.flags;
 
-	const onProgress = verbose ? logEvent : noop;
+	// Only use onProgress for verbose mode when not in dry-run
+	// In dry-run mode, we print the files at the end instead
+	const onProgress = verbose && !dryRun ? logEvent : noop;
 
-	const files = await deleteAsync(cli.input, {onProgress, ...flags});
+	const files = await deleteAsync(cli.input, {onProgress, dryRun, ...flags});
 
-	if (cli.flags.dryRun) {
+	if (dryRun && files.length > 0) {
 		console.log(files.join('\n'));
 	}
 }

readme.md

@@ -22,7 +22,7 @@ $ del --help
 
   Options
     --force, -f    Allow deleting the current working directory and outside
-    --dry-run, -d  List what would be deleted instead of deleting
+    --dry-run, -d  List what would be deleted instead of deleting (silent if no matches)
     --verbose, -v  Display the absolute path of files and directories as they are deleted
 
   Examples

test.js

@@ -19,3 +19,34 @@ test('verbose file does not exist', async t => {
 	const {stdout} = await execa('./cli.js', ['--verbose', 'does-not-exist.txt']);
 	t.is(stdout, '');
 });
+
+test('dry-run with files to delete', async t => {
+	const filename = tempWrite.sync('foo');
+	const {stdout} = await execa('./cli.js', ['--dry-run', '--force', filename]);
+	t.is(stdout, filename);
+	// File should still exist after dry run
+	t.true(fs.existsSync(filename));
+});
+
+test('dry-run with no files to delete', async t => {
+	const {stdout} = await execa('./cli.js', ['--dry-run', 'does-not-exist-*.txt']);
+	t.is(stdout, '');
+});
+
+test('verbose + dry-run does not duplicate output', async t => {
+	const filename = tempWrite.sync('foo');
+	const {stdout} = await execa('./cli.js', ['--verbose', '--dry-run', '--force', filename]);
+	// Should only print the filename once, not twice
+	t.is(stdout, filename);
+});
+
+test('verbose + dry-run with multiple files', async t => {
+	const file1 = tempWrite.sync('foo');
+	const file2 = tempWrite.sync('bar');
+	const {stdout} = await execa('./cli.js', ['--verbose', '--dry-run', '--force', file1, file2]);
+	const lines = stdout.split('\n');
+	// Should have exactly 2 lines (one per file)
+	t.is(lines.length, 2);
+	t.true(lines.includes(file1));
+	t.true(lines.includes(file2));
+});