prefer-spread: Fix: Skip TypedArray and ArrayBuffer constructor calls (#2871)

Author: kaigritun

rules/prefer-spread.js

@@ -9,6 +9,7 @@ import {
 } from './utils/index.js';
 import {removeMethodCall} from './fix/index.js';
 import {isLiteral, isMethodCall} from './ast/index.js';
+import typedArrayTypes from './shared/typed-array.js';
 
 const ERROR_ARRAY_FROM = 'array-from';
 const ERROR_ARRAY_CONCAT = 'array-concat';
@@ -41,6 +42,29 @@ const ignoredSliceCallee = [
 	'this',
 ];
 
+// TypedArray and ArrayBuffer constructors - these have .slice() but spreading them
+// either doesn't work (ArrayBuffer has no iterator) or changes the type (TypedArray.slice()
+// returns the same typed array, but spreading converts to number[])
+const typedArrayConstructors = new Set([
+	...typedArrayTypes,
+	'ArrayBuffer',
+	'SharedArrayBuffer',
+]);
+
+/**
+Check if node is a TypedArray/ArrayBuffer construction (new Uint8Array(...)).
+
+@param {import('estree').Node} node
+@returns {boolean}
+*/
+function isTypedArrayConstruction(node) {
+	return (
+		node.type === 'NewExpression'
+		&& node.callee.type === 'Identifier'
+		&& typedArrayConstructors.has(node.callee.name)
+	);
+}
+
 const isArrayLiteral = node => node.type === 'ArrayExpression';
 const isArrayLiteralHasTrailingComma = (node, sourceCode) => {
 	if (node.elements.length === 0) {
@@ -416,6 +440,12 @@ const create = context => {
 			return;
 		}
 
+		// Skip TypedArray/ArrayBuffer constructions - spreading them either fails
+		// (ArrayBuffer has no iterator) or changes the type (TypedArray -> number[])
+		if (isTypedArrayConstruction(node.callee.object)) {
+			return;
+		}
+
 		const [firstArgument] = node.arguments;
 		if (firstArgument && !isLiteral(firstArgument, 0)) {
 			return;

test/prefer-spread.js

@@ -314,6 +314,24 @@ test.snapshot({
 		'file.slice()',
 		'class A {foo() {this.slice()}}',
 		'scopeManager?.scopes.slice()',
+		// TypedArray/ArrayBuffer constructors - spreading doesn't work or changes type
+		'new ArrayBuffer(10).slice()',
+		'new ArrayBuffer(10).slice(0)',
+		'new SharedArrayBuffer(10).slice()',
+		'new SharedArrayBuffer(10).slice(0)',
+		'new Int8Array([1, 2, 3]).slice()',
+		'new Int8Array([1, 2, 3]).slice(0)',
+		'new Uint8Array([10, 20, 30, 40, 50]).slice()',
+		'new Uint8Array([10, 20, 30, 40, 50]).slice(0)',
+		'new Uint8ClampedArray([1, 2, 3]).slice()',
+		'new Int16Array([1, 2, 3]).slice()',
+		'new Uint16Array([1, 2, 3]).slice()',
+		'new Int32Array([1, 2, 3]).slice()',
+		'new Uint32Array([1, 2, 3]).slice()',
+		'new Float32Array([1, 2, 3]).slice()',
+		'new Float64Array([1, 2, 3]).slice()',
+		'new BigInt64Array([1n, 2n, 3n]).slice()',
+		'new BigUint64Array([1n, 2n, 3n]).slice()',
 	],
 	invalid: [
 		'array.slice()',
@@ -328,9 +346,8 @@ test.snapshot({
 			bar()
 			foo.slice()
 		`,
-		// `{String,TypedArray}#slice` are wrongly detected
+		// `String#slice` is wrongly detected (strings are iterable but spreading produces array, not string)
 		'"".slice()',
-		'new Uint8Array([10, 20, 30, 40, 50]).slice()',
 		'array.slice(0)',
 		'array.slice(0b0)',
 		'array.slice(0.00)',

test/snapshots/prefer-spread.js.md

@@ -2322,26 +2322,7 @@ Generated by [AVA](https://avajs.dev).
       1 | [...""]␊
     `
 
-## invalid(10): new Uint8Array([10, 20, 30, 40, 50]).slice()
-
-> Input
-
-    `␊
-      1 | new Uint8Array([10, 20, 30, 40, 50]).slice()␊
-    `
-
-> Error 1/1
-
-    `␊
-    Message:␊
-    > 1 | new Uint8Array([10, 20, 30, 40, 50]).slice()␊
-        |                                      ^^^^^ Prefer the spread operator over \`Array#slice()\`.␊
-    ␊
-    Output:␊
-      1 | [...new Uint8Array([10, 20, 30, 40, 50])]␊
-    `
-
-## invalid(11): array.slice(0)
+## invalid(10): array.slice(0)
 
 > Input
 
@@ -2360,7 +2341,7 @@ Generated by [AVA](https://avajs.dev).
       1 | [...array]␊
     `
 
-## invalid(12): array.slice(0b0)
+## invalid(11): array.slice(0b0)
 
 > Input
 
@@ -2379,7 +2360,7 @@ Generated by [AVA](https://avajs.dev).
       1 | [...array]␊
     `
 
-## invalid(13): array.slice(0.00)
+## invalid(12): array.slice(0.00)
 
 > Input
 
@@ -2398,7 +2379,7 @@ Generated by [AVA](https://avajs.dev).
       1 | [...array]␊
     `
 
-## invalid(14): array.slice(0.00, )
+## invalid(13): array.slice(0.00, )
 
 > Input