Fix: Use empty prerelease default for pre-major bump

Fixes #786

Author: sindresorhus

source/ui.js

@@ -414,8 +414,7 @@ const ui = async ({packageManager, ...options}, {package_, rootDirectory}) => {
 		prereleasePrefix: {
 			type: 'input',
 			message: 'Prerelease identifier',
-			// Use || not ?? to treat empty string as falsy (show 'rc' instead of empty default)
-			default: defaultPrereleasePrefix || 'rc',
+			default: defaultPrereleasePrefix,
 			when(answers) {
 				// Only ask when a prerelease increment was selected from the menu
 				if (!answers.version) {

test/_helpers/mock-inquirer.js

@@ -24,20 +24,24 @@ Logs for debugging are outputted on test failure.
 @param {Answers} o.inputAnswers Test input
 @param {Record<string, Prompt> | Prompt[]} o.prompts Actual prompts
 */
-const mockPrompt = async ({t, inputAnswers, prompts}) => {
-	const answers = {};
-
-	// Ensure `prompts` is an object
+const getPromptsObject = prompts => {
 	if (Array.isArray(prompts)) {
 		const promptsObject = {};
 
 		for (const prompt of prompts) {
 			promptsObject[prompt.name] = prompt;
 		}
 
-		prompts = promptsObject;
+		return promptsObject;
 	}
 
+	return prompts;
+};
+
+const mockPrompt = async ({t, inputAnswers, prompts}) => {
+	const answers = {};
+	prompts = getPromptsObject(prompts);
+
 	t.log('prompts:', Object.keys(prompts));
 
 	/* eslint-disable no-await-in-loop */
@@ -193,19 +197,23 @@ Mocks `inquirer` for testing `source/ui.js`.
 @param {ExecutionContext} o.t
 @param {Answers} o.answers Test input
 @param {import('esmock').MockMap} [o.mocks] Optional global mocks
+@param {(prompts: Record<string, Prompt>) => void} [o.onPrompt] Optional hook to inspect prompts
 */
-export const mockInquirer = async ({t, answers, mocks = {}}) => {
+export const mockInquirer = async ({t, answers, mocks = {}, onPrompt = () => {}}) => {
 	/** @type {string[]} */
 	const logs = [];
 
 	/** @type {import('../../source/ui.js')} */
 	const ui = await esmock('../../source/ui.js', import.meta.url, {
 		inquirer: {
 			async prompt(prompts) {
+				const promptDescriptors = getPromptsObject(prompts);
+				onPrompt(promptDescriptors);
+
 				let uiAnswers = {};
 
 				const assertions = await t.try(async tt => {
-					uiAnswers = await mockPrompt({t: tt, inputAnswers: answers, prompts});
+					uiAnswers = await mockPrompt({t: tt, inputAnswers: answers, prompts: promptDescriptors});
 				});
 
 				assertions.commit({retainLogs: !assertions.passed});

test/ui/prompts/version.js

@@ -233,3 +233,54 @@ test('releaseDraftOnly does not throw on current version', async t => {
 	t.true(results.confirm);
 	t.is(results.version, '1.0.0');
 });
+
+test('uses empty prerelease identifier by default when no prerelease identifier is configured', async t => {
+	let capturedPrereleasePrefixPrompt;
+
+	const {ui} = await mockInquirer({
+		t,
+		answers: {
+			version: 'premajor',
+			prereleasePrefix: '',
+		},
+		onPrompt(prompts) {
+			capturedPrereleasePrefixPrompt = prompts.prereleasePrefix;
+		},
+		mocks: {
+			'./npm/util.js': {
+				checkIgnoreStrategy: sinon.stub().resolves(),
+			},
+			'./util.js': {
+				getNewFiles: sinon.stub().resolves({unpublished: [], firstTime: []}),
+				getNewDependencies: sinon.stub().resolves([]),
+				getPreReleasePrefix: sinon.stub().resolves(''),
+			},
+			'./git-util.js': {
+				latestTagOrFirstCommit: sinon.stub().resolves('v1.0.0'),
+				commitLogFromRevision: sinon.stub().resolves('abc 123'),
+			},
+			execa: {
+				execa: sinon.stub().resolves({stdout: 'https://registry.npmjs.org/'}),
+			},
+		},
+	});
+
+	const {version} = await ui({
+		packageManager,
+		runPublish: false,
+		availability: {},
+	}, {
+		package_: {
+			name: 'foo',
+			version: '1.0.0',
+			files: ['*'],
+			repository: {
+				url: 'https://github.com/foo/bar',
+			},
+		},
+	});
+
+	t.truthy(capturedPrereleasePrefixPrompt);
+	t.is(capturedPrereleasePrefixPrompt.default, '', 'the prerelease identifier default should remain empty');
+	t.is(version.toString(), '2.0.0-0');
+});