Skip to content

Commit b50aaa8

Browse files
committed
Fix checkbox field not setting false values
1 parent 4117f15 commit b50aaa8

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/models/MondayColumn.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ public function getValue()
4747
return null;
4848

4949
case self::TYPE_CHECKBOX:
50-
return $this->value ? ['checked' => 'true'] : ['checked' => 'false'];
50+
// Need to send empty value instead of checked = false to uncheck
51+
return filter_var($this->value, FILTER_VALIDATE_BOOLEAN) === true ? ['checked' => 'true'] : null;
5152

5253
}
5354

tests/feature/ItemServiceTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ public function it_updates_an_item()
4141
$itemId = $this->mondayItemService->createItem(287994487, "new_group82", "Test " . Carbon::now());
4242

4343
$updatedItemId = $this->mondayItemService->updateItem((int)$itemId, 287994487, [
44-
new MondayColumn("text8", MondayColumn::TYPE_TEXT, "THE DEMO CO"),
45-
new MondayColumn("name", MondayColumn::TYPE_TEXT, "DEMO CO"),
44+
new MondayColumn("text8", MondayColumn::TYPE_TEXT, "THE DEMO CO TRUE"),
45+
new MondayColumn("name", MondayColumn::TYPE_TEXT, "Test TRUE"),
4646
new MondayColumn("activeproperties", MondayColumn::TYPE_NUMERIC, "700"),
4747
new MondayColumn("lastticketlogged", MondayColumn::TYPE_DATE, Carbon::now()),
4848
new MondayColumn("check", MondayColumn::TYPE_CHECKBOX, true)

0 commit comments

Comments
 (0)