[BUGFIX] [Docker] running pyright (at lint / static check time) fails due pyright tries to install nodejs. Wrong image was selected an then fail due alpine restrictions. Now a python + nodejs (installed by alpine package manager) image is used at lint time.

Author: Gonzalo Diaz

Dockerfile

@@ -5,16 +5,15 @@ ENV WORKDIR=/app
 WORKDIR ${WORKDIR}
 
 ###############################################################################
-FROM node:20.14.0-alpine3.20 AS lint
+FROM base AS lint
 
 ENV WORKDIR=/app
 WORKDIR ${WORKDIR}
 
 COPY ./src ${WORKDIR}/src
-RUN apk add --update --no-cache make
-RUN npm install -g --ignore-scripts markdownlint-cli
+RUN apk add --update --no-cache make nodejs npm
 
-RUN apk add --update --no-cache nodejs npm
+RUN npm install -g --ignore-scripts markdownlint-cli
 RUN npm install -g --ignore-scripts pyright
 
 ###############################################################################

Makefile

@@ -110,6 +110,7 @@ clean:
 	find . -path "*/__pycache__" -type d -print -exec rm -fr {} ';'
 
 compose/build: env
+	docker-compose --profile lint build
 	docker-compose --profile testing build
 
 compose/rebuild: env
@@ -118,10 +119,10 @@ compose/rebuild: env
 
 compose/mdlint: env
 	docker-compose --profile lint build
-	docker-compose --profile lint run --rm algorithm-exercises-py-mdlint make mdlint
+	docker-compose --profile lint run --rm algorithm-exercises-py-lint make mdlint
 
 compose/test/static: compose/build
-	docker-compose --profile testing run --rm algorithm-exercises-py make test/static
+	docker-compose --profile lint run --rm algorithm-exercises-py-lint make test/static
 
 compose/lint: compose/test/static compose/mdlint
 

compose.yaml

@@ -11,8 +11,8 @@ services:
       - ./coverage:/app/coverage
     profiles: ["testing"]
 
-  algorithm-exercises-py-mdlint:
-    image: algorithm-exercises-ts:mdlint
+  algorithm-exercises-py-lint:
+    image: algorithm-exercises-py:lint
     build:
       context: .
       target: lint