Skip to content

Full screenshot / screenshot with scroll support? #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
happywhitelake opened this issue Mar 3, 2019 · 6 comments
Closed

Full screenshot / screenshot with scroll support? #792

happywhitelake opened this issue Mar 3, 2019 · 6 comments

Comments

@happywhitelake
Copy link

Is there any arg/flag that I can add to make the full screenshot of a page if the page needs to be scrolled down to get the full view? Currently, Browsertime seems to only take the upper area of a given webpage.

@happywhitelake happywhitelake changed the title Full screenshot? Full screenshot / screenshot with scroll support? Mar 3, 2019
@soulgalore
Copy link
Member

Hi @phongiswindy not at the moment. It takes the viewport. The last time (but that was maybe a couple of years ago) webdriver (that we use through Selenium) didn't support full screenshots. I've checked again and it seems to be the issue: w3c/webdriver#1283

But it seems to be a workaround for Firefox, but I haven't looked if there's one for Chrome.

Best
Peter

@happywhitelake
Copy link
Author

@soulgalore, thank you for the prompt reply. I would love to see this implemented. I am currently using browsertime with firefox, I would be really thankful if you could give me some pointers to any aforementioned workarounds out there.

@soulgalore
Copy link
Member

It looks like Geckodriver should support it now: https://bugzilla.mozilla.org/show_bug.cgi?id=1431148 but I haven't looked at how to actually use it. This os low prio for me but if you can do a PR I could look at it.

Best
Peter

@ozcoder
Copy link

ozcoder commented Mar 6, 2019

I'm using these flags to get a long (and big) screenshot
--screenshotParams.maxSize=4504 --viewPort="1024x4580"
As a workaround. But the images are huge, about 14Mb PNG, or 2Mb JPG @ 75%

@happywhitelake
Copy link
Author

@ozcoder Thank you for the tips, that definitely help if we know the size of the page in advance. But the size is dynamic in my case. I guess I will need to write some script later to chop the white space of the taken image. But thank you for the suggestion.

@soulgalore
Copy link
Member

Closing, let us open a new issue when webdriver supports it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants