Skip to content
This repository was archived by the owner on Jun 5, 2019. It is now read-only.

Commit 1dbd612

Browse files
authored
Merge pull request #33 from skellock/even-moar-typings
Even moar typings
2 parents d297215 + 1727c4a commit 1dbd612

File tree

8 files changed

+21
-69
lines changed

8 files changed

+21
-69
lines changed

package-lock.json

+6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
},
5252
"description": "An electron starter project.",
5353
"devDependencies": {
54+
"@types/electron-store": "1.2.0",
5455
"@types/mousetrap": "1.5.34",
5556
"@types/react": "15.0.38",
5657
"@types/react-dom": "15.5.2",

src/main/updater/updater.ts

+6-7
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { autoUpdater } from 'electron-updater'
2-
import { ProgressInfo } from 'electron-builder-http/out/ProgressCallbackTransform'
32
import * as log from 'electron-log'
43
import * as isDev from 'electron-is-dev'
54

@@ -50,24 +49,24 @@ export function createUpdater(app: Electron.App): void {
5049
log.info('checking for update')
5150
})
5251

53-
autoUpdater.on('update-available', info => {
52+
autoUpdater.on('update-available', (info: string) => {
5453
log.info('update available')
5554
})
5655

57-
autoUpdater.on('update-not-available', info => {
56+
autoUpdater.on('update-not-available', (info: string) => {
5857
log.info('update not available')
5958
})
6059

61-
autoUpdater.on('error', err => {
60+
autoUpdater.on('error', (err: Error) => {
6261
log.error('error updating', err.message)
6362
})
6463

65-
autoUpdater.on('download-progress', (progressObj: ProgressInfo) => {
66-
log.info(`${progressObj.percent}%`)
64+
autoUpdater.signals.progress(info => {
65+
log.info(`${info.percent}%`)
6766
})
6867

6968
// fires when an update has been downloaded
70-
autoUpdater.on('update-downloaded', info => {
69+
autoUpdater.signals.updateDownloaded(info => {
7170
log.info('update downloaded')
7271
autoUpdater.quitAndInstall()
7372
})

src/renderer/features/example-using-tabs/welcome-screen/welcome-screen.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { SampleTabs, SampleTabType } from './sample-tabs'
44
import { LongTab } from '../long-tab/long-tab'
55
import { DogTab } from '../dog-tab/dog-tab'
66
import { Header } from '../header/header'
7-
import * as Store from 'electron-store'
7+
import Store = require('electron-store')
88

99
// a sample store
1010
const store = new Store()

src/renderer/platform/components/tab/tab.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ const FIRST_STYLE: CSSProperties = { marginLeft: 0 }
3333
export function Tab(props: TabProps) {
3434
const style: CSSProperties = {
3535
...ROOT_STYLE,
36-
...props.active && ACTIVE_STYLE,
37-
...props.first && FIRST_STYLE,
36+
...props.active ? ACTIVE_STYLE : null,
37+
...props.first ? FIRST_STYLE : null,
3838
...props.style
3939
}
4040
return (

tsconfig.json

+2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
"moduleResolution": "node",
66
"jsx": "react",
77
"experimentalDecorators": true,
8+
"allowSyntheticDefaultImports": false,
9+
"strict": true,
810
"noUnusedLocals": true
911
}
1012
}

types/electron-is-dev.d.ts

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
declare module 'electron-is-dev' {
2+
export const isDev: boolean
3+
}

types/electron-store.d.ts

-59
This file was deleted.

0 commit comments

Comments
 (0)