Skip to content

Commit 4036cb1

Browse files
erock2112Skia Commit-Bot
authored and
Skia Commit-Bot
committed
[recipes] Re-disable SKPs on iOS and images on GPU in nanobench
These were accidentally enabled in https://skia-review.googlesource.com/c/skia/+/274553 which changed the order of the flags. Change-Id: I6d9eb3d5c78baa5bc0d987fa61fe2b1ce305b138 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/274856 Reviewed-by: Eric Boren <[email protected]> Commit-Queue: Eric Boren <[email protected]>
1 parent d690044 commit 4036cb1

File tree

5 files changed

+104
-112
lines changed

5 files changed

+104
-112
lines changed

infra/bots/gen_tasks_logic/nano_flags.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,11 @@ func nanobenchFlags(bot string, parts map[string]string, doUpload bool) ([]strin
2727
}
2828

2929
if has("GPU") {
30-
args = append(args, "--images")
3130
args = append(args, "--gpuStatsDump", "true")
3231
}
3332

3433
args = append(args, "--scales", "1.0", "1.1")
3534

36-
if has("iOS") {
37-
args = append(args, "--skps", "ignore_skps")
38-
}
39-
4035
configs := []string{}
4136
if parts["cpu_or_gpu"] == "CPU" {
4237
args = append(args, "--nogpu")

infra/bots/recipes/perf.expected/Perf-Ubuntu18-Clang-Golo-GPU-QuadroP400-x86_64-Release-All-Valgrind_SK_CPU_LIMIT_SSE41.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,9 +163,7 @@
163163
"-i",
164164
"[START_DIR]/skia/resources",
165165
"--skps",
166-
"[START_DIR]/skp",
167-
"--images",
168-
"[START_DIR]/skimage/nanobench"
166+
"[START_DIR]/skp"
169167
],
170168
"env": {
171169
"CHROME_HEADLESS": "1",

infra/bots/recipes/perf.expected/Perf-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Release-All-ANGLE.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,6 @@
197197
"[START_DIR]\\skia\\resources",
198198
"--skps",
199199
"[START_DIR]\\skp",
200-
"--images",
201-
"[START_DIR]\\skimage\\nanobench",
202200
"--svgs",
203201
"[START_DIR]\\svg",
204202
"--outResultsFile",

infra/bots/recipes/perf.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,13 @@ def perf_steps(api):
6969
args.extend([k, v])
7070

7171
# Paths to required resources.
72-
args.extend([
73-
'-i', api.flavor.device_dirs.resource_dir,
74-
'--skps', api.flavor.device_dirs.skp_dir,
75-
'--images', api.flavor.device_path_join(
76-
api.flavor.device_dirs.images_dir, 'nanobench'),
77-
])
72+
args.extend(['-i', api.flavor.device_dirs.resource_dir])
73+
if 'iOS' not in b:
74+
args.extend(['--skps', api.flavor.device_dirs.skp_dir]),
75+
if 'GPU' not in b:
76+
args.extend(['--images', api.flavor.device_path_join(
77+
api.flavor.device_dirs.images_dir, 'nanobench')])
78+
7879
if api.vars.builder_cfg.get('cpu_or_gpu') == 'CPU' and 'Android' in b:
7980
assert api.flavor.device_dirs.texttraces_dir
8081
args.extend(['--texttraces', api.flavor.device_dirs.texttraces_dir])

0 commit comments

Comments
 (0)