Skip to content

Commit d8b939e

Browse files
drWulfSkia Commit-Bot
authored andcommitted
Revert "Rename getTopDevice/getDevice to topDevice/baseDevice"
This reverts commit 632a23a. Reason for revert: breaking android roll Original change's description: > Rename getTopDevice/getDevice to topDevice/baseDevice > > This addresses nit from https://skia-review.googlesource.com/c/skia/+/344663 > and also moves topDevice() to be private, since it's not really meant > for arbitrary subclasses to access anyways. Classes outside of SkCanvas > that need topDevice/baseDevice are already friended anyways. > > Bug: skia:10987 > Change-Id: Ib0b0dffb5b1c35d5a0c78aeb8903e4cf0b8810a9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/344960 > Reviewed-by: Mike Klein <[email protected]> > Reviewed-by: Mike Reed <[email protected]> > Commit-Queue: Michael Ludwig <[email protected]> [email protected],[email protected],[email protected] Change-Id: I9b70230f7db5d31cede2ea03e7abc7c154021204 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:10987 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/345158 Reviewed-by: Derek Sollenberger <[email protected]> Commit-Queue: Derek Sollenberger <[email protected]>
1 parent 7acddf5 commit d8b939e

File tree

4 files changed

+78
-87
lines changed

4 files changed

+78
-87
lines changed

include/core/SkCanvas.h

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2586,6 +2586,8 @@ class SK_API SkCanvas {
25862586
bool clipRectBounds(const SkRect* bounds, SkIRect* intersection,
25872587
const SkImageFilter* imageFilter = nullptr);
25882588

2589+
SkBaseDevice* getTopDevice() const;
2590+
25892591
private:
25902592
static void DrawDeviceWithFilter(SkBaseDevice* src, const SkImageFilter* filter,
25912593
SkBaseDevice* dst, const SkIPoint& dstOrigin,
@@ -2602,15 +2604,7 @@ class SK_API SkCanvas {
26022604
void predrawNotify(bool willOverwritesEntireSurface = false);
26032605
void predrawNotify(const SkRect* rect, const SkPaint* paint, ShaderOverrideOpacity);
26042606

2605-
// The bottom-most device in the stack, only changed by init(). Image properties and the final
2606-
// canvas pixels are determined by this device.
2607-
SkBaseDevice* baseDevice();
2608-
const SkBaseDevice* baseDevice() const;
2609-
2610-
// The top-most device in the stack, will change within saveLayer()'s. All drawing and clipping
2611-
// operations should route to this device.
2612-
SkBaseDevice* topDevice();
2613-
const SkBaseDevice* topDevice() const;
2607+
SkBaseDevice* getDevice() const;
26142608

26152609
class MCRec;
26162610

0 commit comments

Comments
 (0)