Skip to content

Commit 54807b6

Browse files
committed
#212 added more detailed handling of android error result
1 parent fde6deb commit 54807b6

File tree

5 files changed

+13
-6
lines changed

5 files changed

+13
-6
lines changed

doc/changelog.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
## Changelog
22

3+
### 2.1.5
4+
5+
- #212 Android authentication result is now `Cancelled` instead of `Failed` if the user presses a button to dismiss the dialog.
6+
37
### 2.1.4
48

59
- #203, #205 fixed mLifecycleObserver related crash on some devices (thx @Seuleuzeuh)

src/Directory.build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<Copyright>Copyright (c) Sven-Michael Stübe</Copyright>
77
<Authors>Sven-Michael Stübe</Authors>
88
<Owners>Sven-Michael Stübe</Owners>
9-
<Version>2.1.4</Version>
9+
<Version>2.1.5</Version>
1010

1111
<PublishRepositoryUrl>true</PublishRepositoryUrl>
1212
<RepositoryUrl>https://github.com/smstuebe/xamarin-fingerprint</RepositoryUrl>

src/MvvmCross.Plugins.Fingerprint/MvvmCross.Plugins.Fingerprint.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="MSBuild.Sdk.Extras">
22
<PropertyGroup>
3-
<TargetFrameworks>netstandard2.0;net461;Xamarin.Mac20;Xamarin.iOS10;Xamarin.TVOS10;Xamarin.WatchOS10;MonoAndroid9;uap10.0.16299;Tizen40;</TargetFrameworks>
3+
<TargetFrameworks>netstandard2.0;net461;Xamarin.Mac20;Xamarin.iOS10;Xamarin.TVOS10;Xamarin.WatchOS10;MonoAndroid9;uap10.0.19041;Tizen40;</TargetFrameworks>
44
<LangVersion>latest</LangVersion>
55
<EnableDefaultCompileItems>false</EnableDefaultCompileItems>
66
<AssemblyName>MvvmCross.Plugins.Fingerprint</AssemblyName>

src/Plugin.Fingerprint/Platforms/Android/AuthenticationHandler.cs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,13 @@ public override void OnAuthenticationError(int errorCode, ICharSequence errStrin
4242
var message = errString != null ? errString.ToString() : string.Empty;
4343
var result = new FingerprintAuthenticationResult { Status = FingerprintAuthenticationResultStatus.Failed, ErrorMessage = message };
4444

45-
if (errorCode == BiometricPrompt.ErrorLockout)
45+
result.Status = errorCode switch
4646
{
47-
result.Status = FingerprintAuthenticationResultStatus.TooManyAttempts;
48-
}
47+
BiometricPrompt.ErrorLockout => FingerprintAuthenticationResultStatus.TooManyAttempts,
48+
BiometricPrompt.ErrorUserCanceled => FingerprintAuthenticationResultStatus.Canceled,
49+
BiometricPrompt.ErrorNegativeButton => FingerprintAuthenticationResultStatus.Canceled,
50+
_ => FingerprintAuthenticationResultStatus.Failed
51+
};
4952

5053
SetResultSafe(result);
5154
}

src/Plugin.Fingerprint/Plugin.Fingerprint.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="MSBuild.Sdk.Extras">
22
<PropertyGroup>
3-
<TargetFrameworks>netstandard2.0;net45;Xamarin.Mac20;Xamarin.iOS10;Xamarin.TVOS10;Xamarin.WatchOS10;MonoAndroid90;uap10.0.16299;Tizen40;</TargetFrameworks>
3+
<TargetFrameworks>netstandard2.0;net45;Xamarin.Mac20;Xamarin.iOS10;Xamarin.TVOS10;Xamarin.WatchOS10;MonoAndroid90;uap10.0.19041;Tizen40;</TargetFrameworks>
44
<LangVersion>8</LangVersion>
55
<EnableDefaultCompileItems>false</EnableDefaultCompileItems>
66

0 commit comments

Comments
 (0)