fix: remove the Indexing progress message when exeption in withHieDb (haskell#3610)

If any exception was happening in `withHieDb`, the `post` action was
never called, leading to a stale `Indexing` message in the client.

By using `bracket`, we ensure that the `post` message is called in the
event of an exception, cleaning the confusing message in the client.

It does not change the well behaving of the indexing (i.e. if it was
crashing, it is still crashing), but at least user won't be confused by
a stale `Indexing` message.

Co-authored-by: Michael Peyton Jones <[email protected]>

Author: 2 people

ghcide/src/Development/IDE/Core/Compile.hs

@@ -901,9 +901,10 @@ indexHieFile se mod_summary srcPath !hash hf = do
             -- If the hash in the pending list doesn't match the current hash, then skip
             Just pendingHash -> pendingHash /= hash
         unless newerScheduled $ do
-          pre optProgressStyle
-          withHieDb (\db -> HieDb.addRefsFromLoaded db targetPath (HieDb.RealFile $ fromNormalizedFilePath srcPath) hash hf')
-          post
+          -- Using bracket, so even if an exception happen during withHieDb call,
+          -- the `post` (which clean the progress indicator) will still be called.
+          bracket_ (pre optProgressStyle) post $
+            withHieDb (\db -> HieDb.addRefsFromLoaded db targetPath (HieDb.RealFile $ fromNormalizedFilePath srcPath) hash hf')
   where
     mod_location    = ms_location mod_summary
     targetPath      = Compat.ml_hie_file mod_location