Skip to content

Conversation

jwarzech
Copy link

Allows the library to be used for more complex tags.

@sniperwolf
Copy link
Owner

Hi @jwarzech,

thank you very much for this pull request, in particularly for the latest commit (jwarzech@87e8c0c), which is actually a fix for a forgetfulness.

I will not merge the commit jwarzech@650872b (and so the jwarzech@9a65d86) because I prefer to use a for loop to verify the boolean value of special keys.

Can you revert these two commit?

@sniperwolf sniperwolf added the bug label Apr 17, 2014
@jwarzech
Copy link
Author

Hi @sniperwolf,

Thanks for creating a tagging library that doesn't require all the bloat of jQuery UI and ThemeRolling!

How would you prefer to have the "no-spacebar" option to be handled? At least for my purposes I need to allow multi-word tags and this option is extremely useful. I've also made some additional updates in my branch:

  • Setting of a placeholder for the input box
  • Added "tag added" and "tag removed" callback functions

@sniperwolf
Copy link
Owner

In v1.3.1 I refactored a little bit the code and enhanced the plugin with methods, that help you to work with taggingJS using JavaScript directly. I think that now is more flexible and also extensible.

Your idea for placeholder and the two callback is great, so I will open other 2 enhancement issue about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants