[refactor] Use Buffer.concat([]) to construct an empty buffer (#555)

darrachequesne · web-flow · commit be3833bdddf5 · 2018-02-27T22:03:31.000+01:00
diff --git a/lib/transports/polling.js b/lib/transports/polling.js
@@ -136,7 +136,7 @@ Polling.prototype.onDataRequest = function (req, res) {
   this.dataReq = req;
   this.dataRes = res;
 
-  var chunks = isBinary ? new Buffer(0) : ''; // eslint-disable-line node/no-deprecated-api
+  var chunks = isBinary ? Buffer.concat([]) : '';
   var self = this;
 
   function cleanup () {
@@ -162,7 +162,7 @@ Polling.prototype.onDataRequest = function (req, res) {
     }
 
     if (contentLength > self.maxHttpBufferSize) {
-      chunks = isBinary ? new Buffer(0) : ''; // eslint-disable-line node/no-deprecated-api
+      chunks = isBinary ? Buffer.concat([]) : '';
       req.connection.destroy();
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ Polling.prototype.onDataRequest = function (req, res) {`
`136`	`136`	`this.dataReq = req;`
`137`	`137`	`this.dataRes = res;`
`138`	`138`
`139`		`- var chunks = isBinary ? new Buffer(0) : ''; // eslint-disable-line node/no-deprecated-api`
	`139`	`+ var chunks = isBinary ? Buffer.concat([]) : '';`
`140`	`140`	`var self = this;`
`141`	`141`
`142`	`142`	`function cleanup () {`
`@@ -162,7 +162,7 @@ Polling.prototype.onDataRequest = function (req, res) {`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`if (contentLength > self.maxHttpBufferSize) {`
`165`		`- chunks = isBinary ? new Buffer(0) : ''; // eslint-disable-line node/no-deprecated-api`
	`165`	`+ chunks = isBinary ? Buffer.concat([]) : '';`
`166`	`166`	`req.connection.destroy();`
`167`	`167`	`}`
`168`	`168`	`}`