Skip to content

Unclear documentation around "channels" #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatanYemini opened this issue May 26, 2023 · 1 comment
Open

Unclear documentation around "channels" #504

MatanYemini opened this issue May 26, 2023 · 1 comment

Comments

@MatanYemini
Copy link

MatanYemini commented May 26, 2023

Hi!

1 question:

From what it seems that channels are according to "namespace" only, and not by roomId.

e.g:

this.channel = prefix + "#" + nsp.name + "#"; this.requestChannel = prefix + "-request#" + this.nsp.name + "#"; this.responseChannel = prefix + "-response#" + this.nsp.name + "#"; this.specificResponseChannel = this.responseChannel + this.uid + "#";

But, in the README.md file, you are suggesting prefix + '#' + namespace + '#' + room + '#' will be the way to distribute a message to a specific room.

I would also add what is the behavior when subscribing to a channel. For example, if room A is at server 1 and room B is at server 2, does sever1 will receive messages that are related to server2 (the load-balancer somehow magically did that each room belongs to 1 server, leave the optimization aside of that ;) )

It's implemented only in the sharded redis adapter? from the code it seems like, but not from the docs

Thanks! Please let me know if I can help somehow with the questions above :))
-m

@MatanYemini MatanYemini changed the title Unclear documentation around "channels" Unclear documentation around "channels" + "local" emit May 27, 2023
@MatanYemini MatanYemini changed the title Unclear documentation around "channels" + "local" emit Unclear documentation around "channels" May 27, 2023
@kucukaslan
Copy link

the change seems to be documented now. However, I still did not understand how is the "nsp" generated when we use room names with socket.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants