update engine.io version to 1.5.4

[vsharmaGit]

engine.io-client has resolved a dependency which was retrieving xmlhttprequest from Github. socket.io 1.3.6 relies on engine.io version 1.5.2. please update engine.io version

[nicofff]

+1

[torvalamo]

It is updated on github, so if you do

npm install git+https://github.com/socketio/socket.io

you've got it.

However there is one bug, which is that engine.io complains that module base64id isn't found. So you need to

npm install base64id

separately, and you're good to go. At least I haven't seen anything bad yet apart from that.

[vsharmaGit]

unfortunately, we don't have GIT installed in our build environment as well this doesn't solve our issue since socket.io is a dependency for browser-sync and karma.

[maxscott]

+1 if you have a direct dependency on socket.io this is enough, but for everyone else, it means forking your real dependenc(ies) and bumping the socket.io reference... I'd love to see a patch release resolving this.

[justerhan]

@torvalamo 's suggestion didn't work for me :( . Very annoying, especially regarding @maxwerr 's point. I used npm's built-in shrinkwrap command (https://docs.npmjs.com/cli/shrinkwrap) to get this working in node v4.0.0. The shrinkwrap command allows you to bump the version number in your dependant packages without having to fork them. You can run the failed npm install command and still generate the proper npm-shrinkwrap.json file then bump the engine.io version. Pretty handy in these kind of situations.

[maxscott]

@BountyX that's really smart. great workaround until this passes tests and gets released..

[jldec]

appears to be fixed in socket.io v1.3.7

[mikermcneil]

@jldec 👍 @rauchg published 1.3.7 yesterday which depends on [email protected]

@vsharmaGit I imagine this can be closed :)

[vsharmaGit]

Awesome...thanks for the update