Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Append fork-abandoning reason as memo ix to vote txes for better visibility #18043

Closed
ryoqun opened this issue Jun 17, 2021 · 2 comments
Closed

Comments

@ryoqun
Copy link
Contributor

ryoqun commented Jun 17, 2021

Problem

skipped reason is hard to tell. and aspiring validator operators wants to know the reason.

Proposed Solution

make each validator's decision visible as a first citizen of information by appending memo instruction to vote transactions, from the side-effect of gossiped vote txes.

maybe like this?

abandoned_forks:
  1232323:
      <ns timestamp>: Reason::FirstShred
      <ns timestamp>: Reason::ReplayAborted
      <ns timestamp>: Reason::Frozen
  2323232:
      <ns timestamp>: Reason::FirstShred
      <ns timestamp>: Reason::Voted
  7777777:
      <ns timestamp>: Reason::FirstShred
      <ns timestamp>: Reason::DuplicateConfirmed
  9999999:
      <ns timestamp>: Reason::FirstShred
      <ns timestamp>: Reason::LockedOut

overhead can be ok? (F = fork, N = number of timeline, T = byte of timestamp, R = byte of reason, F * (size_of<Slot> + N * (T + R)) assume F = 5, N = 10, T = 4, R = 2 => 5 * (8 + 10 * (4 + 2)) => 340 bytes` per vote.

so, 10,000 votes/sec => 3.4 MBps overhead?

also, squeeze timestamp bytes with offset us (u32) and base time (u64)?

also, this will be used for casual diagnostics, so no need to protect it under consensus-level security.
tagging: @carllin @behzadnouri

@ryoqun
Copy link
Contributor Author

ryoqun commented Aug 19, 2021

well, I'm abandoning this whole idea, I ended up creating what I wanted via influx metrics. and it seems enough, although it excludes nodes without metrics enabled.: #18308 (comment)

@ryoqun ryoqun closed this as completed Aug 19, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

This issue has been automatically locked since there has not been any activity in past 7 days after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant