Merge pull request #81 from yungyuc/test/ci-new-os

Add Ubuntu 22.04 and macos 12 to pytest build job

Author: yungyuc

.clang-tidy

@@ -1,5 +1,6 @@
 Checks: >
     *,-clang-analyzer-alpha.*,-hicpp-*,
+    -clang-diagnostic-ignored-optimization-argument,
     -altera-*,
     -abseil-*,
     -bugprone-macro-parentheses,
@@ -18,12 +19,14 @@ Checks: >
     -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
     -cppcoreguidelines-pro-bounds-constant-array-index,
     -cppcoreguidelines-pro-bounds-pointer-arithmetic,
+    -google-readability-casting,
     -google-readability-todo,
     -google-runtime-references,
     -hicpp-signed-bitwise,
     -llvm-header-guard,
     -llvm-include-order,
     -performance-noexcept-move-constructor,
+    -readability-identifier-length,
     -readability-named-parameter,
     -readability-magic-numbers,
     -readability-redundant-access-specifiers,

.github/workflows/modmesh_install.yml

@@ -28,19 +28,19 @@ jobs:
         fetch-depth: 1
 
     - name: dependency (ubuntu)
-      if: matrix.os != 'macos-11'
+      if: ${{ startsWith(matrix.os, 'ubuntu') }}
       run: |
         sudo apt-get -qqy update
         sudo apt-get -qy install \
-            sudo curl git build-essential make cmake libc6-dev gcc-10 g++-10 \
+            sudo curl git build-essential make cmake libc6-dev gcc g++ \
             clang-tidy-10 \
             python3 python3-dev python3-venv
         sudo ln -s "$(which clang-tidy-10)" "$(dirname $(which clang-tidy-10))/clang-tidy"
         sudo pip3 install setuptools
         sudo pip3 install numpy pytest flake8
 
     - name: dependency (macos)
-      if: matrix.os == 'macos-11'
+      if: ${{ startsWith(matrix.os, 'macos') }}
       run: |
         brew install python3 llvm
         ln -s "$(brew --prefix llvm)/bin/clang-format" "/usr/local/bin/clang-format"

.github/workflows/modmesh_pytest.yml

@@ -17,7 +17,7 @@ jobs:
 
     strategy:
         matrix:
-          os: [ubuntu-20.04, macos-11]
+          os: [ubuntu-20.04, ubuntu-22.04, macos-11, macos-12]
           cmake_build_type: [Release, Debug]
 
         fail-fast: false
@@ -29,19 +29,21 @@ jobs:
         fetch-depth: 1
 
     - name: dependency (ubuntu)
-      if: matrix.os != 'macos-11'
+      if: ${{ startsWith(matrix.os, 'ubuntu') }}
       run: |
+        VERSION_ID=$(bash -c 'source /etc/os-release ; echo $VERSION_ID')        
+        if [ "20.04" == "$VERSION_ID" ] ; then CLANG_TIDY_VERSION=10 ; else CLANG_TIDY_VERSION=14 ; fi
         sudo apt-get -qqy update
         sudo apt-get -qy install \
-            sudo curl git build-essential make cmake libc6-dev gcc-10 g++-10 \
-            clang-tidy-10 \
+            sudo curl git build-essential make cmake libc6-dev gcc g++ \
+            clang-tidy-${CLANG_TIDY_VERSION} \
             python3 python3-dev python3-venv
-        sudo ln -s "$(which clang-tidy-10)" "$(dirname $(which clang-tidy-10))/clang-tidy"
+        sudo ln -s "$(which clang-tidy-${CLANG_TIDY_VERSION})" "$(dirname $(which clang-tidy-${CLANG_TIDY_VERSION}))/clang-tidy"
         sudo pip3 install setuptools
         sudo pip3 install numpy pytest flake8
 
     - name: dependency (macos)
-      if: matrix.os == 'macos-11'
+      if: ${{ startsWith(matrix.os, 'macos') }}
       run: |
         brew install python3 llvm
         ln -s "$(brew --prefix llvm)/bin/clang-format" "/usr/local/bin/clang-format"

.github/workflows/modmesh_viewer.yml

@@ -27,11 +27,11 @@ jobs:
         fetch-depth: 1
 
     - name: dependency (ubuntu)
-      if: matrix.os != 'macos-11'
+      if: ${{ startsWith(matrix.os, 'ubuntu') }}
       run: |
         sudo apt-get -qqy update
         sudo apt-get -qy install \
-            sudo curl git build-essential make cmake libc6-dev gcc-10 g++-10 \
+            sudo curl git build-essential make cmake libc6-dev gcc g++ \
             python3 python3-dev python3-venv \
             qt6-3d-dev
         # TODO: not figure out why this is needed. Without this package, we do

CMakeLists.txt

@@ -75,7 +75,13 @@ include(GNUInstallDirs)
 
 set(MODMESH_PY_DIR "${PROJECT_SOURCE_DIR}/modmesh")
 
-set(COMMON_COMPILER_OPTIONS -Werror -Wall -Wextra)
+set(COMMON_COMPILER_OPTIONS -Wall -Wextra)
+if(USE_CLANG_TIDY AND LINT_AS_ERRORS)
+    message(STATUS "Disable -Werror because clang-tidy (with lint as errors) is enabled")
+else()
+    set(COMMON_COMPILER_OPTIONS ${COMMON_COMPILER_OPTIONS} -Werror)
+    message(STATUS "Enable -Werror because clang-tidy (with lint as errors) is disabled")
+endif()
 
 add_subdirectory(cpp/binary/pymod_modmesh)
 if(BUILD_QT)

contrib/dependency/apt.ubuntu-2204.sh

@@ -0,0 +1,7 @@
+# Install system tools.
+apt-get -qy install sudo curl git
+# Install compiler and build tools.
+apt-get -qy install build-essential make cmake libc6-dev gcc g++ clang-tidy-14
+# Install Python.
+apt-get -qy install python3 python3-dev python3-env python3-setuptools python3.10-dev
+apt-get -qy install python3-numpy python3-pytest python3-flake8