Prevent HTML injection #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes !106
I thought it'd be better to sanitize the output before hitting the output modifiers as building output modifiers yourself will still contain the HTML injections unless you specifically address this in your output modifier.
|
Thanks! |
|
@freekmurze isn't it a better idea to just DOMPurify the output on the client, instead of straight up nuking the output on the server? That way I'm not sure we should drop the styling in order to fix this issue, especially because this little note. |
|
@xHeaven That might be better, yeah. I'd be open for a PR that adds that. |
Alright, I'll open a PR a bit later this afternoon reverting this change and implementing the HTML purifying on the client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately these changes also mean that things like
var_dump(...)anddd(...)will not render on the page but instead will show up as plain text. I'm not sure if there is a way to get Web Tinker to behave the same way as the Tinker shell would inside of a terminal, meaning it'd use a different strategy for things likevar_dump(...)anddd(...).Closes #106.