Skip to content

url validation fails for gitsm #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
billie-alsup opened this issue Aug 6, 2024 · 1 comment
Closed

url validation fails for gitsm #819

billie-alsup opened this issue Aug 6, 2024 · 1 comment

Comments

@billie-alsup
Copy link

The supported_download_repos list in validation/uri_validators.py is missing gitsm

supported_download_repos: str = "(git|hg|svn|bzr)"

Our OpenEmbedded build produces three SPDX files using gitsm:

recipes/recipe-bcc.spdx.json:      "downloadLocation": "gitsm+https://github.com/iovisor/bcc@942227484d3207f6a42103674001ef01fb5335a0",
recipes/recipe-ovmf.spdx.json:      "downloadLocation": "gitsm+https://github.com/tianocore/edk2.git@06dc822d045c2bb42e497487935485302486e151",
recipes/recipe-ovmf-native.spdx.json:      "downloadLocation": "gitsm+https://github.com/tianocore/edk2.git@06dc822d045c2bb42e497487935485302486e151",

gitsm is the bitbake submodule fetcher.

@billie-alsup
Copy link
Author

I have looked at the SPDX 2.3.0 specification

In section 7.7.1 (Package download location field description), it simply mentions a URL, NONE, or NOASSERTION.

However, in section 7.7.3 Examples, it explicitly lists supported git schemes, and gitsm is not mentioned. So it seems that I need to handle this in the application, whether in the SPDX generator, or possibly pushing the problem back to the yocto environment. Certainly a given git SHA1 would be sufficient to identify the submodules' SHA1 as well, but I think it might be better to list each submodule (recursively) as an independent package, with independent supplier/originator/license/etc. Of course the relationship between the packages can be listed in the relationships section as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant