Skip to content

(v2) Migrate to importlib.util.find_spec for Python 3.14 compatibility #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisinmtown wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

(v2) Migrate to importlib.util.find_spec for Python 3.14 compatibility #2099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions connexion/apps/aiohttp_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
This module defines an AioHttpApp, a Connexion application to wrap an AioHttp application.
"""

import importlib.util
import logging
import pathlib
import pkgutil
import sys

from aiohttp import web
Expand All @@ -30,11 +30,11 @@ def get_root_path(self):
if mod is not None and hasattr(mod, "__file__"):
return pathlib.Path(mod.__file__).resolve().parent

loader = pkgutil.get_loader(self.import_name)
spec = importlib.util.find_spec(self.import_name)
filepath = None

if hasattr(loader, "get_filename"):
filepath = loader.get_filename(self.import_name)
if hasattr(spec, "loader") and hasattr(spec.loader, "get_filename"):
filepath = spec.loader.get_filename(self.import_name)

if filepath is None:
raise RuntimeError(f"Invalid import name '{self.import_name}'")
Expand Down