Merge pull request #478 from imageworks/clippy-config

Custom clippy configuration

Author: jrray

.clippy.toml

@@ -0,0 +1,5 @@
+# default is 3
+max-fn-params-bools = 1
+
+# default is 7
+too-many-arguments-threshold = 5

crates/parsedbuf/src/lib.rs

@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub use paste;
 

crates/spfs-cli/cmd-clean/src/cmd_clean.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use chrono::prelude::*;
 use clap::Parser;
 use colored::*;

crates/spfs-cli/cmd-enter/src/cmd_enter.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use std::ffi::OsString;
 
 use clap::Parser;

crates/spfs-cli/cmd-join/src/cmd_join.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use std::ffi::OsString;
 
 use clap::Parser;

crates/spfs-cli/cmd-monitor/src/cmd_monitor.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use std::time::Duration;
 
 use clap::Parser;

crates/spfs-cli/common/src/lib.rs

@@ -1,3 +1,6 @@
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 //! Common macros and argument structures for the spfs command line
 
 mod args;

crates/spfs-cli/main/src/bin.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use clap::{Parser, Subcommand};
 use spfs::Error;
 

crates/spfs-encoding/src/lib.rs

@@ -12,6 +12,7 @@
 
 #![deny(missing_docs)]
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 mod binary;
 mod error;

crates/spfs/src/lib.rs

@@ -2,9 +2,10 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
-//! Filesystem isolation, capture and distribution.
-
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
+//! Filesystem isolation, capture and distribution.
 
 pub const VERSION: &str = env!("CARGO_PKG_VERSION");
 

crates/spfs/src/resolve_test.rs

@@ -1,8 +1,9 @@
-use std::sync::Arc;
-
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
+use std::sync::Arc;
+
 use rstest::rstest;
 
 use super::resolve_stack_to_layers;

crates/spk-build/src/lib.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod build;
 mod error;
 

crates/spk-cli/cmd-build/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_build;

crates/spk-cli/cmd-convert/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_convert;

crates/spk-cli/cmd-env/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_env;

crates/spk-cli/cmd-explain/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_explain;

crates/spk-cli/cmd-install/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_install;

crates/spk-cli/cmd-make-binary/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_make_binary;

crates/spk-cli/cmd-make-source/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_make_source;

crates/spk-cli/cmd-render/src/cmd_render.rs

@@ -1,6 +1,10 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 use std::path::PathBuf;
 
 use anyhow::{bail, Context, Result};

crates/spk-cli/cmd-render/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_render;

crates/spk-cli/cmd-repo/src/lib.rs

@@ -3,5 +3,6 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_repo;

crates/spk-cli/cmd-test/src/lib.rs

@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_test;
 

crates/spk-cli/common/src/lib.rs

@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 mod cli;
 mod env;

crates/spk-cli/group1/src/lib.rs

@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_bake;
 pub mod cmd_deprecate;

crates/spk-cli/group2/src/lib.rs

@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_ls;
 pub mod cmd_new;

crates/spk-cli/group3/src/lib.rs

@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_export;
 pub mod cmd_import;

crates/spk-cli/group4/src/lib.rs

@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod cmd_lint;
 pub mod cmd_search;

crates/spk-exec/src/lib.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod error;
 mod exec;
 

crates/spk-schema/crates/foundation/src/lib.rs

@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub mod env;
 pub mod fixtures;

crates/spk-schema/crates/ident/src/lib.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod error;
 mod format;
 mod ident;

crates/spk-schema/crates/validators/src/lib.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod error;
 mod validators;
 

crates/spk-schema/src/lib.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod build_spec;
 mod component_spec;
 mod component_spec_list;

crates/spk-solve/crates/graph/src/lib.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod error;
 mod graph;
 

crates/spk-solve/crates/package-iterator/src/build_key_test.rs

@@ -34,6 +34,7 @@ fn make_tag_part(pieces: Vec<&str>) -> Option<Vec<BuildKeyVersionNumberPiece>> {
 
 // For making test case results
 #[allow(clippy::too_many_arguments)]
+#[allow(clippy::fn_params_excessive_bools)]
 fn make_expanded_version_range_part(
     version: &str,
     max_digits: Vec<u32>,

crates/spk-solve/crates/package-iterator/src/lib.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod build_key;
 mod error;
 mod package_iterator;

crates/spk-solve/crates/solution/src/lib.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod error;
 mod solution;
 

crates/spk-solve/crates/validation/src/lib.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod error;
 mod impossible_checks;
 mod validation;

crates/spk-solve/src/lib.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod error;
 mod io;
 mod macros;

crates/spk-storage/src/lib.rs

@@ -2,6 +2,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
 
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 mod error;
 pub mod fixtures;
 mod storage;

crates/spk/src/cli.rs

@@ -1,6 +1,10 @@
 // Copyright (c) Sony Pictures Imageworks, et al.
 // SPDX-License-Identifier: Apache-2.0
 // https://github.com/imageworks/spk
+
+#![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
+
 //! Main entry points and utilities for command line interface and interaction.
 
 use anyhow::{Context, Result};

crates/spk/src/lib.rs

@@ -3,6 +3,7 @@
 // https://github.com/imageworks/spk
 
 #![deny(unsafe_op_in_unsafe_fn)]
+#![warn(clippy::fn_params_excessive_bools)]
 
 pub use {
     spk_build as build,