Skip to content

Commit 2d5ddc0

Browse files
committed
Remove parameter in call
1 parent 0ae1017 commit 2d5ddc0

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

src/test/java/io/split/android/client/network/SslProxyTunnelEstablisherTest.java

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public void establishTunnelWithValidSslProxySucceeds() throws Exception {
9595
targetHost,
9696
targetPort,
9797
clientSslSocketFactory,
98-
proxyCredentialsProvider, false);
98+
proxyCredentialsProvider);
9999

100100
assertNotNull("Tunnel socket should not be null", tunnelSocket);
101101
assertTrue("Tunnel socket should be connected", tunnelSocket.isConnected());
@@ -124,8 +124,7 @@ public void establishTunnelWithNotTrustedCertificatedThrows() throws Exception {
124124
"example.com",
125125
443,
126126
untrustedSocketFactory,
127-
proxyCredentialsProvider,
128-
false);
127+
proxyCredentialsProvider);
129128
fail("Should have thrown exception for untrusted certificate");
130129
} catch (IOException e) {
131130
assertTrue("Exception should be SSL-related", e.getMessage().contains("certification"));
@@ -144,8 +143,7 @@ public void establishTunnelWithFailingProxyConnectionThrows() {
144143
"example.com",
145144
443,
146145
clientSslSocketFactory,
147-
proxyCredentialsProvider,
148-
false);
146+
proxyCredentialsProvider);
149147
fail("Should have thrown exception for connection failure");
150148
} catch (IOException e) {
151149
// The implementation wraps the original exception with a descriptive message
@@ -167,7 +165,7 @@ public void bearerTokenIsPassedWhenSet() throws IOException, InterruptedExceptio
167165
public String getToken() {
168166
return "token";
169167
}
170-
}, false);
168+
});
171169
boolean await = testProxy.getAuthorizationHeaderReceived().await(5, TimeUnit.SECONDS);
172170
assertTrue("Proxy should have received authorization header", await);
173171
}
@@ -182,7 +180,7 @@ public void establishTunnelWithNullCredentialsProviderDoesNotAddAuthHeader() thr
182180
"example.com",
183181
443,
184182
clientSslSocketFactory,
185-
null, false);
183+
null);
186184

187185
assertNotNull(tunnelSocket);
188186
assertTrue(testProxy.getConnectRequestReceived().await(5, TimeUnit.SECONDS));
@@ -207,7 +205,7 @@ public void establishTunnelWithNullBearerTokenDoesNotAddAuthHeader() throws Exce
207205
public String getToken() {
208206
return null;
209207
}
210-
}, false);
208+
});
211209

212210
assertNotNull(tunnelSocket);
213211
assertTrue(testProxy.getConnectRequestReceived().await(5, TimeUnit.SECONDS));
@@ -232,7 +230,7 @@ public void establishTunnelWithEmptyBearerTokenDoesNotAddAuthHeader() throws Exc
232230
public String getToken() {
233231
return "";
234232
}
235-
}, false);
233+
});
236234

237235
assertNotNull(tunnelSocket);
238236
assertTrue(testProxy.getConnectRequestReceived().await(5, TimeUnit.SECONDS));
@@ -269,7 +267,7 @@ public void establishTunnelWithMalformedStatusLineThrowsIOException() {
269267
"example.com",
270268
443,
271269
clientSslSocketFactory,
272-
null, false));
270+
null));
273271

274272
assertNotNull(exception);
275273
}
@@ -285,7 +283,7 @@ public void establishTunnelWithProxyAuthRequiredThrowsHttpRetryException() {
285283
"example.com",
286284
443,
287285
clientSslSocketFactory,
288-
null, false));
286+
null));
289287

290288
assertEquals(407, exception.responseCode());
291289
}

0 commit comments

Comments
 (0)