RBS Storage provider (#742)

Author: gthea

src/main/java/io/split/android/client/dtos/MatcherType.java

@@ -60,5 +60,8 @@ public enum MatcherType {
     @SerializedName("BETWEEN_SEMVER")
     BETWEEN_SEMVER,
     @SerializedName("IN_LIST_SEMVER")
-    IN_LIST_SEMVER
+    IN_LIST_SEMVER,
+
+    @SerializedName("IN_RULE_BASED_SEGMENT")
+    IN_RULE_BASED_SEGMENT,
 }

src/main/java/io/split/android/client/localhost/LocalhostRuleBasedSegmentsStorage.java

@@ -0,0 +1,43 @@
+package io.split.android.client.localhost;
+
+import androidx.annotation.NonNull;
+import androidx.annotation.Nullable;
+
+import java.util.Set;
+
+import io.split.android.client.dtos.RuleBasedSegment;
+import io.split.android.client.storage.rbs.RuleBasedSegmentStorage;
+
+public class LocalhostRuleBasedSegmentsStorage implements RuleBasedSegmentStorage {
+
+    @Nullable
+    @Override
+    public RuleBasedSegment get(String segmentName) {
+        return null;
+    }
+
+    @Override
+    public boolean update(@NonNull Set<RuleBasedSegment> toAdd, @NonNull Set<RuleBasedSegment> toRemove, long changeNumber) {
+        return false;
+    }
+
+    @Override
+    public long getChangeNumber() {
+        return -1;
+    }
+
+    @Override
+    public boolean contains(@NonNull Set<String> segmentNames) {
+        return false;
+    }
+
+    @Override
+    public void loadLocal() {
+        // no-op
+    }
+
+    @Override
+    public void clear() {
+        // no-op
+    }
+}

src/main/java/io/split/android/client/localhost/LocalhostRuleBasedSegmentsStorageProvider.java

@@ -0,0 +1,20 @@
+package io.split.android.client.localhost;
+
+import androidx.annotation.NonNull;
+
+import io.split.android.client.storage.rbs.RuleBasedSegmentStorage;
+import io.split.android.client.storage.rbs.RuleBasedSegmentStorageProvider;
+
+class LocalhostRuleBasedSegmentsStorageProvider implements RuleBasedSegmentStorageProvider {
+    
+    private final RuleBasedSegmentStorage mRuleBasedSegmentStorage;
+    
+    LocalhostRuleBasedSegmentsStorageProvider(@NonNull RuleBasedSegmentStorage ruleBasedSegmentStorage) {
+        mRuleBasedSegmentStorage = ruleBasedSegmentStorage;
+    }
+
+    @Override
+    public RuleBasedSegmentStorage get() {
+        return mRuleBasedSegmentStorage;
+    }
+}

src/main/java/io/split/android/client/storage/db/StorageFactory.java

@@ -30,6 +30,10 @@
 import io.split.android.client.storage.mysegments.MySegmentsStorageContainer;
 import io.split.android.client.storage.mysegments.MySegmentsStorageContainerImpl;
 import io.split.android.client.storage.mysegments.SqLitePersistentMySegmentsStorage;
+import io.split.android.client.storage.rbs.LazyRuleBasedSegmentStorageProvider;
+import io.split.android.client.storage.rbs.PersistentRuleBasedSegmentStorage;
+import io.split.android.client.storage.rbs.RuleBasedSegmentStorageProvider;
+import io.split.android.client.storage.rbs.SqLitePersistentRuleBasedSegmentStorageProvider;
 import io.split.android.client.storage.splits.PersistentSplitsStorage;
 import io.split.android.client.storage.splits.SplitsStorage;
 import io.split.android.client.storage.splits.SplitsStorageImpl;
@@ -154,4 +158,12 @@ public static PersistentImpressionsObserverCacheStorage getImpressionsObserverCa
     public static GeneralInfoStorage getGeneralInfoStorage(SplitRoomDatabase splitRoomDatabase) {
         return new GeneralInfoStorageImpl(splitRoomDatabase.generalInfoDao());
     }
+
+    public static PersistentRuleBasedSegmentStorage getPersistentRuleBasedSegmentStorage(SplitRoomDatabase splitRoomDatabase, SplitCipher splitCipher, GeneralInfoStorage generalInfoStorage) {
+        return new SqLitePersistentRuleBasedSegmentStorageProvider(splitCipher, splitRoomDatabase, generalInfoStorage).get();
+    }
+
+    public static RuleBasedSegmentStorageProvider getRuleBasedSegmentStorageProvider() {
+        return new LazyRuleBasedSegmentStorageProvider();
+    }
 }

src/main/java/io/split/android/client/storage/rbs/LazyRuleBasedSegmentStorageProvider.java

@@ -0,0 +1,25 @@
+package io.split.android.client.storage.rbs;
+
+import androidx.annotation.NonNull;
+import androidx.annotation.Nullable;
+
+import java.util.concurrent.atomic.AtomicReference;
+
+import io.split.android.client.utils.logger.Logger;
+
+public class LazyRuleBasedSegmentStorageProvider implements RuleBasedSegmentStorageProvider {
+    
+    private final AtomicReference<RuleBasedSegmentStorage> mRuleBasedSegmentStorageRef = new AtomicReference<>();
+    
+    public void set(@NonNull RuleBasedSegmentStorage ruleBasedSegmentStorage) {
+        if (!mRuleBasedSegmentStorageRef.compareAndSet(null, ruleBasedSegmentStorage)) {
+            Logger.w("RuleBasedSegmentStorage already set in LazyRuleBasedSegmentStorageProvider");
+        }
+    }
+    
+    @Nullable
+    @Override
+    public RuleBasedSegmentStorage get() {
+        return mRuleBasedSegmentStorageRef.get();
+    }
+}

src/main/java/io/split/android/client/storage/rbs/RuleBasedSegmentStorageProvider.java

@@ -0,0 +1,9 @@
+package io.split.android.client.storage.rbs;
+
+import androidx.annotation.Nullable;
+
+public interface RuleBasedSegmentStorageProvider {
+
+    @Nullable
+    RuleBasedSegmentStorage get();
+}

src/test/java/io/split/android/client/storage/rbs/LazyRuleBasedSegmentStorageProviderTest.java

@@ -0,0 +1,29 @@
+package io.split.android.client.storage.rbs;
+
+import static org.junit.Assert.assertNotSame;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertSame;
+import static org.mockito.Mockito.mock;
+
+import org.junit.Test;
+
+public class LazyRuleBasedSegmentStorageProviderTest {
+
+    @Test
+    public void refCanOnlyBeSetOnce() {
+        LazyRuleBasedSegmentStorageProvider provider = new LazyRuleBasedSegmentStorageProvider();
+        RuleBasedSegmentStorage firstInstance = mock(RuleBasedSegmentStorage.class);
+        RuleBasedSegmentStorage secondInstance = mock(RuleBasedSegmentStorage.class);
+        provider.set(firstInstance);
+        provider.set(secondInstance);
+
+        assertSame(firstInstance, provider.get());
+        assertNotSame(secondInstance, provider.get());
+    }
+
+    @Test
+    public void getReturnsNullWhenSetHasNotBeenCalled() {
+        LazyRuleBasedSegmentStorageProvider provider = new LazyRuleBasedSegmentStorageProvider();
+        assertNull(provider.get());
+    }
+}