feat: add browser argument #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdoroszko-splunk
requested review from
artemrys,
mbruzda-splunk and
mkolasinski-splunk
Contributor
There was a problem hiding this comment.
@kdoroszko-splunk as this change is breaking change, I'd propose to make it feat release.
Contributor
Author
Done. |
mkolasinski-splunk
approved these changes
May 27, 2024
srv-rr-github-token
added a commit
that referenced
this pull request
May 27, 2024
# [5.0.0](v4.0.0...v5.0.0) (2024-05-27) ### Features * add browser argument ([#27](#27)) ([65871c3](65871c3)) ### BREAKING CHANGES * add test-browser argument (test browser type). Related PRs: - splunk/addonfactory-workflow-addon-release#261 (reusable workflow PR will have to be updated [by this changes](splunk/addonfactory-workflow-addon-release@ui-markers...fix/ui-markers)) - splunk/ta-automation-app-of-apps#9 Test runs: - [test-addonfactory-repo](https://github.com/splunk/test-addonfactory-repo/actions/runs/9193209865/job/25284182463) - [splunk-add-on-for-amazon-web-services](https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/9192893030/job/25283275525)
Contributor
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: add test-browser argument (test browser type).
Related PRs:
Test runs:
test-addonfactory-repo
splunk-add-on-for-amazon-web-services