Surround debug statements with checks to see if debug logging is enabled

#436 (comment)

Author: fhanik

samples/service-provider/starter/src/main/java/org/springframework/security/saml2/serviceprovider/authentication/Saml2AuthenticationProvider.java

@@ -157,7 +157,9 @@ private Assertion validateSaml2Response(Saml2ServiceProviderRegistration sp, Str
 		}
 
 		final String issuer = samlResponse.getIssuer().getValue();
-		logger.debug("Processing SAML response from " + issuer);
+		if (logger.isDebugEnabled()) {
+			logger.debug("Processing SAML response from " + issuer);
+		}
 		final Saml2IdentityProviderDetails idp = serviceProviderRepository
 			.getIdentityProviders(sp.getEntityId())
 			.getIdentityProviderById(issuer);
@@ -211,7 +213,9 @@ private boolean isValidAssertion(Saml2ServiceProviderRegistration sp, String rec
 		}
 
 		if (signatureRequired && !hasValidSignature(a, idp)) {
-			logger.debug(format("Assertion [%s] does not a valid signature.", a.getID()));
+			if (logger.isDebugEnabled()) {
+				logger.debug(format("Assertion [%s] does not a valid signature.", a.getID()));
+			}
 			return false;
 		}
 		a.setSignature(null);
@@ -222,13 +226,18 @@ private boolean isValidAssertion(Saml2ServiceProviderRegistration sp, String rec
 			final ValidationResult result = validator.validate(a, vctx);
 			final boolean valid = result.equals(ValidationResult.VALID);
 			if (!valid) {
-				logger.debug(format("Failed to validate assertion from %s with user %s", idp.getEntityId(),
-						getUsername(sp, a)));
+				if (logger.isDebugEnabled()) {
+					logger.debug(format("Failed to validate assertion from %s with user %s", idp.getEntityId(),
+						getUsername(sp, a)
+					));
+				}
 			}
 			return valid;
 		}
 		catch (AssertionValidationException e) {
-			logger.debug("Failed to validate assertion:", e);
+			if (logger.isDebugEnabled()) {
+				logger.debug("Failed to validate assertion:", e);
+			}
 			return false;
 		}
 

samples/service-provider/starter/src/main/java/org/springframework/security/saml2/serviceprovider/servlet/filter/Saml2AuthenticationFailureHandler.java

@@ -44,7 +44,9 @@ public Saml2AuthenticationFailureHandler() {
 	@Override
 	public void onAuthenticationFailure(HttpServletRequest request, HttpServletResponse response,
 			AuthenticationException exception) throws IOException, ServletException {
-		logger.debug("Processing SAML2 Authentication Exception", exception);
+		if (logger.isDebugEnabled()) {
+			logger.debug("Processing SAML2 Authentication Exception", exception);
+		}
 		sendHtmlBody(response, errorHtml(Collections.singletonList(exception.getMessage())));
 	}
 

samples/service-provider/starter/src/main/java/org/springframework/security/saml2/serviceprovider/servlet/filter/Saml2AuthenticationRequestFilter.java

@@ -68,7 +68,9 @@ private void sendAuthenticationRequest(HttpServletRequest request,
 										   HttpServletResponse response) throws IOException {
 		String relayState = request.getParameter("RelayState");
 		String alias = getIdpAlias(request);
-		logger.debug("Creating SAML2 SP Authentication Request for IDP["+alias+"]");
+		if (logger.isDebugEnabled()) {
+			logger.debug("Creating SAML2 SP Authentication Request for IDP[" + alias + "]");
+		}
 		Assert.hasText(alias, "IDP Alias must be present and valid");
 		Saml2ServiceProviderRegistration sp = serviceProviderRepository.getServiceProvider(getBasePath(request, false));
 		Saml2IdentityProviderDetails idp = getIdentityProvider(sp, alias);
@@ -81,7 +83,9 @@ private void sendAuthenticationRequest(HttpServletRequest request,
 			.build(true)
 			.toUriString();
 		response.sendRedirect(redirect);
-		logger.debug("SAML2 SP Authentication Request Sent to Browser");
+		if (logger.isDebugEnabled()) {
+			logger.debug("SAML2 SP Authentication Request Sent to Browser");
+		}
 
 	}