Skip to content

Commit dda6d3c

Browse files
committed
Unncessary warning for multiple functions found
Currently we show a warning for multiple functions found even when there are no functions found and spring.cloud.function.definition is not set. Resolves #1011
1 parent 69e29e3 commit dda6d3c

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

spring-cloud-function-context/src/main/java/org/springframework/cloud/function/context/catalog/BeanFactoryAwareFunctionRegistry.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
import org.springframework.lang.Nullable;
5454
import org.springframework.messaging.Message;
5555
import org.springframework.messaging.converter.CompositeMessageConverter;
56+
import org.springframework.util.CollectionUtils;
5657
import org.springframework.util.StringUtils;
5758

5859
/**
@@ -126,8 +127,10 @@ public <T> T lookup(Class<?> type, String functionDefinition, String... expected
126127
.filter(name -> !RoutingFunction.FUNCTION_NAME.equals(name))
127128
.filter(name -> !RoutingFunction.DEFAULT_ROUTE_HANDLER.equals(name))
128129
.collect(Collectors.toList());
129-
logger.warn("Multiple functional beans were found " + functionalBeans + ", thus can't determine default function definition. Please "
130+
if (!CollectionUtils.isEmpty(functionalBeans) && functionalBeans.size() > 1) {
131+
logger.warn("Multiple functional beans were found " + functionalBeans + ", thus can't determine default function definition. Please "
130132
+ "use 'spring.cloud.function.definition' property to explicitly define it. ");
133+
}
131134
}
132135
if (!isFunctionDefinitionEligible(functionDefinition)) {
133136
return null;

0 commit comments

Comments
 (0)